[$250] Task – App crashes when click on assignee in existing task

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4989792
Email or phone of affected tester (no customers): applausetester+jpcategory_2@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Open any chat
4. Create a task without assignee
5. Open task details and click on assignee

Expected Result:

Assignee list opens

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2009.txt

Bug6609721_1726820372331.Assignee_crash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838194512143553982
• Upwork Job ID: 1838194512143553982
• Last Price Increase: 2024-09-23
• Automatic offers:
• jjcoffee | Reviewer | 104086587
• nkdengineer | Contributor | 104086588

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when click on assignee in existing task

What is the root cause of that problem?

Use 'report' before initialization

App/src/pages/tasks/TaskAssigneeSelectorModal.tsx

Line 127 in 4c9a3fb

if (report && !ReportUtils.isTaskReport(report)) {

What changes do you think we should make in order to solve the problem?

Delay using the report until the report is complete.

// .src/pages/tasks/TaskAssigneeSelectorModal.tsx#L127
    const report: OnyxEntry<Report> = useMemo(() => {
        if (!route.params?.reportID) {
            return;
        }

+        InteractionManager.runAfterInteractions(() => {
+            requestAnimationFrame(() => {
                if (report && !ReportUtils.isTaskReport(report)) {
                    Navigation.isNavigationReady().then(() => {
                        Navigation.dismissModal(report.reportID);
                    });
                }
+            });
+        });

        return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    }, [reports, route]);

POC

Screen.Recording.2024-09-20.at.16.04.35.mp4

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes

What is the root cause of that problem?

The report is used before it's initialize

App/src/pages/tasks/TaskAssigneeSelectorModal.tsx

Lines 123 to 129 in 4c9a3fb

	const report: OnyxEntry<Report> = useMemo(() => {
	if (!route.params?.reportID) {
	return;
	}
	if (report && !ReportUtils.isTaskReport(report)) {
	Navigation.isNavigationReady().then(() => {
	Navigation.dismissModal(report.reportID);

What changes do you think we should make in order to solve the problem?

Update this to get the report data from reports to check it's task report or not

const report: OnyxEntry<Report> = useMemo(() => {
    if (!route.params?.reportID) {
        return;
    }
    const reportOnyx = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    if (reportOnyx && !ReportUtils.isTaskReport(reportOnyx)) {
        Navigation.isNavigationReady().then(() => {
            Navigation.dismissModal(reportOnyx.reportID);
        });
    }
    return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
}, [reports, route]);

What alternative solutions did you explore? (Optional)

Or we can move the navigate logic to another useEffect

const report: OnyxEntry<Report> = useMemo(() => {
    if (!route.params?.reportID) {
        return;
    }
    return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
}, [reports, route]);

useEffect(() => {
    if (report && !ReportUtils.isTaskReport(report)) {
        Navigation.isNavigationReady().then(() => {
            Navigation.dismissModal(report.reportID);
        });
    }
}, [report]);

[flodnv]

Why did this just start happening upon this deploy? What PR caused this?

[nkdengineer]

@flodnv Maybe it is caused by #48325. I tried to revert to the latest commit in production and install node-module again and the bug didn't happen. The bug started happening when I reverted to the first different between production and staging and re-install node-module again.

[grgia]

This is from #49241

See slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1726837086718439?thread_ts=1726822044.310019&cid=C01GTK53T8Q

[grgia]

Updated #49241 cc @luacmartins

[rayane-djouah]

Updated #49241 cc @luacmartins

This is not the offending PR. I tried reverting it locally, and I'm still able to reproduce the bug.

[flodnv]

@flodnv Maybe it is caused by #48325. I tried to revert to the latest commit in production and install node-module again and the bug didn't happen. The bug started happening when I reverted to the first different between production and staging and re-install node-module again.

Thanks @nkdengineer. @rojiphil @BrtqKr can you please check if #48325 caused this?

[BrtqKr]

@flodnv, I don't think this would be related. Seems like accessing report from task is making this work

    const report: OnyxEntry<Report> = useMemo(() => {
        if (!route.params?.reportID) {
            return;
        }
        if (task?.report && !ReportUtils.isTaskReport(task?.report)) {
            Navigation.isNavigationReady().then(() => {
                Navigation.dismissModal(task?.report?.reportID);
            });
        }
        return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    }, [reports, route]);

currently, the memo is accessing itself and it seems to be the reason, why this bug is occurring, but this is quite surprising because it's been working like this for a while somehow

    const report: OnyxEntry<Report> = useMemo(() => {
        if (!route.params?.reportID) {
            return;
        }
        if (report && !ReportUtils.isTaskReport(report)) {
            Navigation.isNavigationReady().then(() => {
                Navigation.dismissModal(report.reportID);
            });
        }
        return reports?.[`${ONYXKEYS.COLLECTION.REPORT}${route.params?.reportID}`];
    }, [reports, route]);

[flodnv]

Right, it is strange. I assigned you @nkdengineer

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838194512143553982

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

Thanks, will raise the PR soon.

[nkdengineer]

@jjcoffee The PR is here

cc @flodnv

[flodnv]

Thanks!

[alexpensify]

Awesome, now we wait for this one to go to Prouduction.

[isagoico]

Retest was a pass 🎉

Recording.2024-09-23.115241.mp4

Checking it off the list.