Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login form - No option to change the password in login and password entry form #4958

Closed
kavimuru opened this issue Aug 31, 2021 · 12 comments
Closed
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Aug 31, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when testing the PR #4880. This issue blocks the PR

Action Performed:

  1. Launch the app
  2. Press sign in without entering anything in the field and verify the error message
  3. Look for the language switcher option

Expected Result:

User should have the option to switch the language

Actual Result:

No option to change the language

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
1.0.90.0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5217969_IMG_1815_1_
Bug5217969_IMG_1814_1_

Expensify/Expensify Issue URL:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Aug 31, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@roryabraham
Copy link
Contributor

@pecanoro I'm the mobile-deployer today and I want to make sure we run a prod deploy so I'm going to snag this from you

@roryabraham roryabraham assigned roryabraham and unassigned pecanoro Aug 31, 2021
@roryabraham
Copy link
Contributor

Still digging on this

@roryabraham
Copy link
Contributor

This is tricky, because I'm not able to reproduce it locally (even on the staging branch)

@roryabraham
Copy link
Contributor

roryabraham commented Aug 31, 2021

JK, I figured this out. It's not being shown because betas are not loaded when not logged in, and the language picker is hidden behind a beta.

@roryabraham
Copy link
Contributor

roryabraham commented Sep 1, 2021

@kavimuru Please retest this in 1.0.90-2, being deployed here

@isagoico
Copy link

isagoico commented Sep 1, 2021

Retest was a pass!

image

image

Only thing I noticed that was off is that the language dropdown has a double border

image

@roryabraham
Copy link
Contributor

Interesting, can we file another issue for that and mark it External please?

@botify
Copy link

botify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

🚀 Deployed to staging by @roryabraham in version: 1.0.90-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 2, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants