Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread – New message button and green line appears when go back to main chat from thread #49751

Closed
3 of 6 tasks
IuliiaHerets opened this issue Sep 25, 2024 · 8 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5006354
Email or phone of affected tester (no customers): applausetester+jpcategory_2@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Open any chat and send 10 messages
  4. Right click on the firs message and select Reply in thread
  5. Send a comment in a thread
  6. Go back to main chat via header link

Expected Result:

New message button not appears

Actual Result:

New message button and green line appears

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6615280_1727297502147.New_message_button_and_green_line_appears_when_go_back_to_main_chat.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 25, 2024
Copy link

melvin-bot bot commented Sep 25, 2024

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Sep 25, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 25, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 25, 2024
@melvin-bot melvin-bot bot removed the Hourly KSv2 label Sep 25, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@marcaaron
Copy link
Contributor

This looks like the most likely culprit: https://github.com/Expensify/App/pull/49367/files

@klajdipaja
Copy link
Contributor

@marcaaron I doubt that's the culprit because this issue has been reported previously in #49525 a week before #49367 was merged

@marcaaron
Copy link
Contributor

cool! I based my guess entirely on the name of the PR.

@c3024
Copy link
Contributor

c3024 commented Sep 27, 2024

The unread marker appearing on coming back from thread is fixed with this PR #49770. That can be CPed to staging.

@AndrewGable
Copy link
Contributor

@dangrous says this one is fixed via the CP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering
Projects
No open projects
Development

No branches or pull requests

6 participants