Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Sign in - User is not redirected to IOU report when logging in after deeplink #49798

Closed
6 tasks done
kavimuru opened this issue Sep 26, 2024 · 10 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Sep 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.40-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5009482
Email or phone of affected tester (no customers): applausetester+kmpr2@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Preconditions: Account with existing IOU report, IOU report URL copied and navigate to some other report

  1. Log out of the app if logged in
  2. Navigate to IOU report URL
  3. Log in with the account from preconditions

Expected Result:

User should be redirected to correct IOU report

Actual Result:

User is not redirected. The app displays LHN.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6616049_1727353307229.staging.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021839359132431419714
  • Upwork Job ID: 1839359132431419714
  • Last Price Increase: 2024-09-26
Issue OwnerCurrent Issue Owner: @ikevin127
@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Sep 26, 2024
Copy link

melvin-bot bot commented Sep 26, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Sep 26, 2024

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 26, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@thienlnam thienlnam added the External Added to denote the issue can be worked on by a contributor label Sep 26, 2024
@melvin-bot melvin-bot bot changed the title Sign in - User is not redirected to IOU report when logging in after deeplink [$250] Sign in - User is not redirected to IOU report when logging in after deeplink Sep 26, 2024
Copy link

melvin-bot bot commented Sep 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021839359132431419714

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 26, 2024
Copy link

melvin-bot bot commented Sep 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@thienlnam
Copy link
Contributor

Possibly from #49516?

@blazejkustra
Copy link
Contributor

Possibly from #49516?

I'll check if it's connected 👍 We're working on a bigger refactor so I could fix it there.

@blazejkustra
Copy link
Contributor

I think it is a regression from 49516, still investigating..

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label Sep 27, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Sep 27, 2024
@jasperhuangg
Copy link
Contributor

Let's retest this on staging and close it out if it looks good there. @Expensify/applause

@thienlnam
Copy link
Contributor

Ah forgot to close this out - but re-tested it and works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants