Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint Errors in tests/perf-test/ReportActionsList.perf-test.tsx #49806

Closed
dangrous opened this issue Sep 26, 2024 · 9 comments
Closed

Fix ESLint Errors in tests/perf-test/ReportActionsList.perf-test.tsx #49806

dangrous opened this issue Sep 26, 2024 · 9 comments
Assignees
Labels
Daily KSv2

Comments

@dangrous
Copy link
Contributor

Encountered ESLint errors in this PR but couldn't fix them there since it was a straight revert. Creating this issue to track the separate fix.

It's 3x replacing measurePerformance with measureRenders in https://github.com/c3024/App/blob/4a6d6d2bc3050157b6e295ff48478fc985dc0604/tests/perf-test/ReportActionsList.perf-test.tsx

@dangrous dangrous added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 26, 2024
Copy link

melvin-bot bot commented Sep 26, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dangrous
Copy link
Contributor Author

@bfitzexpensify this is followup from #49770 - I don't think we need to handle payment etc. on here

@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2024
@bfitzexpensify
Copy link
Contributor

Deployed to prod - @dangrous, any further action needed here?

@melvin-bot melvin-bot bot removed the Overdue label Oct 1, 2024
@dangrous
Copy link
Contributor Author

dangrous commented Oct 1, 2024

nope I think we can close - nothing actually needed here now.

@dangrous dangrous closed this as completed Oct 1, 2024
@dangrous
Copy link
Contributor Author

dangrous commented Oct 1, 2024

oh wait I lied, we might need to keep this open for completion, but we won't need payment either way. Checking in Slack.

@dangrous dangrous reopened this Oct 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2024
@bfitzexpensify
Copy link
Contributor

@dangrous is there a PR linked to this I can keep an eye on? Is it just https://github.com/Expensify/App/pull/49770/files?

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2024
@s77rt
Copy link
Contributor

s77rt commented Oct 4, 2024

I think we can close this. There is no real need in taking any action here. The next PR that makes changes to tests/perf-test/ReportActionsList.perf-test.tsx shall fix the deprecation warnings

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
Copy link

melvin-bot bot commented Oct 7, 2024

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@dangrous
Copy link
Contributor Author

dangrous commented Oct 8, 2024

Yeah I was originally thinking we needed to handle this as a follow up, but since it was just a revert and not original code, I think it's okay to close this out until it's fixed by the next update to that file. Thanks all!

@dangrous dangrous closed this as completed Oct 8, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants