-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESLint Errors in tests/perf-test/ReportActionsList.perf-test.tsx #49806
Comments
Triggered auto assignment to @bfitzexpensify ( |
@bfitzexpensify this is followup from #49770 - I don't think we need to handle payment etc. on here |
Deployed to prod - @dangrous, any further action needed here? |
nope I think we can close - nothing actually needed here now. |
oh wait I lied, we might need to keep this open for completion, but we won't need payment either way. Checking in Slack. |
@dangrous is there a PR linked to this I can keep an eye on? Is it just https://github.com/Expensify/App/pull/49770/files? |
I think we can close this. There is no real need in taking any action here. The next PR that makes changes to |
@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Yeah I was originally thinking we needed to handle this as a follow up, but since it was just a revert and not original code, I think it's okay to close this out until it's fixed by the next update to that file. Thanks all! |
Encountered ESLint errors in this PR but couldn't fix them there since it was a straight revert. Creating this issue to track the separate fix.
It's 3x replacing
measurePerformance
withmeasureRenders
in https://github.com/c3024/App/blob/4a6d6d2bc3050157b6e295ff48478fc985dc0604/tests/perf-test/ReportActionsList.perf-test.tsxThe text was updated successfully, but these errors were encountered: