Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createPrerelease is run and fails when a deploy is canceled due to cancel-in-progress #49851

Closed
AndrewGable opened this issue Sep 27, 2024 · 2 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@AndrewGable
Copy link
Contributor

Problem

We had a deploy error on https://github.com/Expensify/App/actions/runs/11074305525/job/30773368164 because the build was canceled due to cancel-in-progress flag.

Solution

@roryabraham says:

I'd say this is expected - the deploy completed on at least one platform (web), so it creates the prerelease.
I think we should just continue-on-error with these non-critical artifact upload steps

@AndrewGable AndrewGable added the Internal Requires API changes or must be handled by Expensify staff label Sep 27, 2024
@roryabraham
Copy link
Contributor

Going to just create a quick PR

@roryabraham
Copy link
Contributor

Should be fixed by #49852. We don't have a great way to test this per-se so I'm going to optimistically close it and we can monitor/reopen if we see it happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants