-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Saved search - Tooltip reappears after it disappears #49873
Comments
Triggered auto assignment to @blimpich ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-control |
Edited by proposal-police: This proposal was edited at 2024-09-27 22:48:30 UTC. ProposalOffending PR: #49682Please re-state the problem that we are trying to solve in this issue.Web - Saved search - Tooltip reappears after it disappears What is the root cause of that problem?We aren't calling
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
Result |
@Krishna2323 since this is marked as a deploy blocker you need to identify what caused the regression in the first place. I don't consider the proposal complete without that. |
In order for me to mark this as external I would want (A) the original contributor and C+ to not be reachable (B) the original PR for some reason shouldn't be reverted because it'll cause more problems then it'll solve and (C) the problem is urgent enough that I don't want to wait for the original contributor to get around to it. For this issue A is true but B and C are not. I think this problem is minor enough that we can demote it and make it follow up work for people who worked on the PR who caused the regression. Not worth reverting over a slightly buggy tooltip IMO. |
Triggered auto assignment to @VictoriaExpensify ( |
@daledah Pls raise the PR, I think we just need to clear the timeout (second one) |
@dukenv0307 Here's the PR |
@blimpich @luacmartins I want to confirm the expectation here
Should we dismiss the tooltip forever when users open the modal when the tooltip is open? If not so, we can see the tooltip re-appear when all modals are hide, then it'll be removed after 5s |
IMO we should do this. Left a comment on the PR. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in prodaction?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The tooltip should not reappear after it disappears
Actual Result:
The tooltip reappears after it disappears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6617794_1727466826401.20240928_035109.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: