Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - When long pressing url, copy to URL to clipboard icon is greyed out #49892

Closed
1 of 6 tasks
lanitochka17 opened this issue Sep 28, 2024 · 8 comments
Closed
1 of 6 tasks

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap on a chat
  3. Enter a url and send message eg- hai.com
  4. Long press the message

Expected Result:

When long pressing url, copy to URL to clipboard icon must be in green

Actual Result:

When long pressing url, copy to URL to clipboard icon is greyed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6617994_1727483207729.Screenrecorder-2024-09-28-05-52-30-233_compress_1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Sep 28, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Sep 28, 2024

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

Production:

Screenshot_20240928-092002_Chrome

@Nodebrute
Copy link
Contributor

I believe this behavior is expected #49569. When we hover over or click on the menu item, the color will change to green.

cc: @ishpaul777 @dubielzyk-expensify

Copy link

melvin-bot bot commented Sep 29, 2024

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

@roryabraham
Copy link
Contributor

@dubielzyk-expensify can you clarify if this is expected or not?

@dubielzyk-expensify
Copy link
Contributor

We actually changed these option rows to now have grey color, so this is as expected.

We made the change here: #49569 (comment)

@roryabraham
Copy link
Contributor

thanks @dubielzyk-expensify!

@roryabraham roryabraham removed the DeployBlockerCash This issue or pull request should block deployment label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants