Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb - Dupe detection - Multiple "resolved the duplicate" message is created #49900

Closed
2 of 6 tasks
lanitochka17 opened this issue Sep 29, 2024 · 7 comments
Closed
2 of 6 tasks
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. [Employee] Submit two expenses that are duplicated
  2. [Admin] Go to the transaction thread of a transaction
  3. [Admin] Review the duplicate and chose any transaction to keep
  4. [Admin] Confirm to resolve the duplicate
  5. Admin] Click the Back button, notice you are returned to "Review duplicates" page
  6. Admin] Click on "confirm"

Expected Result:

Clicking the Back button does not take to "Review duplicates" page

Actual Result:

Clicking the Back button takes you back to "Review duplicates" page. And confirming creates multiple "resolved the duplicate" and "Held this Expense" messages in the report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6618105_1727499573819.w_8d7e527aabe95eb0bc3ad9f2d60df4af80fa2f33.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021840789692182968366
  • Upwork Job ID: 1840789692182968366
  • Last Price Increase: 2024-09-30
Issue OwnerCurrent Issue Owner: @dukenv0307
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Sep 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Sep 29, 2024

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@Gonals Gonals removed the DeployBlocker Indicates it should block deploying the API label Sep 30, 2024
@Gonals
Copy link
Contributor

Gonals commented Sep 30, 2024

Only happening in one platform, so not a Web-E blocker

@neil-marcellini neil-marcellini added the External Added to denote the issue can be worked on by a contributor label Sep 30, 2024
@melvin-bot melvin-bot bot changed the title mWeb - Dupe detection - Multiple "resolved the duplicate" message is created [$250] mWeb - Dupe detection - Multiple "resolved the duplicate" message is created Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021840789692182968366

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@neil-marcellini
Copy link
Contributor

This is also reproducible on Mac Chrome on a small screen

Screen.Recording.2024-09-30.at.11.41.05.AM.mov

@jasperhuangg
Copy link
Contributor

This was fixed in #49953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants