Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Deeplink - Infinite loading displayed when clicked on open in app button #49902

Closed
1 of 6 tasks
lanitochka17 opened this issue Sep 29, 2024 · 32 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5016926
Email or phone of affected tester (no customers): rybkina@gmail.com, rybkina+092024@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Sign in with account A in desktop app and account B in web
  2. Open staging.new.expensify.com in web any chat
  3. Reload the page
  4. Click on button "Open New Expensify" on pop-up "Open New Expensify?"

Expected Result:

Chat selected on step 2 should be open after redirected to desktop app and signed in with account B

Actual Result:

Infinite loading displayed when user redirected to the desktop app. But seeting page shown all info about user B

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6618589_1727538907497.redirect_infinity.mp4
54 40

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846257436627573924
  • Upwork Job ID: 1846257436627573924
  • Last Price Increase: 2024-11-05
Issue OwnerCurrent Issue Owner: @rayane-djouah
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Sep 29, 2024
Copy link

melvin-bot bot commented Sep 29, 2024

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Gonals
Copy link
Contributor

Gonals commented Sep 30, 2024

@lanitochka17, can this be consistently reproduced?

@Gonals Gonals removed the DeployBlocker Indicates it should block deploying the API label Sep 30, 2024
@Gonals
Copy link
Contributor

Gonals commented Sep 30, 2024

Seems to be frontend, so removing Web-E blocker

@MarioExpensify
Copy link
Contributor

Checking frontend

@MarioExpensify
Copy link
Contributor

I was able to reproduce it in staging, trying to debug and check latest commits to find out what happened

@MarioExpensify
Copy link
Contributor

As this seem to be an edge case (multiple logins being switched through web and desktop apps) caused by a frontend change, I'll investigate it further and take action accordingly. Meanwhile I'm removing the DeployBlocker for the app.

@MarioExpensify MarioExpensify added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2024
@MarioExpensify
Copy link
Contributor

Still looking into this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 3, 2024
@MarioExpensify MarioExpensify added Weekly KSv2 and removed Daily KSv2 labels Oct 7, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@MarioExpensify
Copy link
Contributor

Making this external.

@MarioExpensify MarioExpensify added the External Added to denote the issue can be worked on by a contributor label Oct 15, 2024
@melvin-bot melvin-bot bot changed the title Deeplink - Infinite loading displayed when clicked on open in app button [$250] Deeplink - Infinite loading displayed when clicked on open in app button Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021846257436627573924

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@rayane-djouah
Copy link
Contributor

Waiting on proposals

Copy link

melvin-bot bot commented Oct 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@rayane-djouah
Copy link
Contributor

Waiting on proposals

@melvin-bot melvin-bot bot removed the Overdue label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

@RachCHopkins, @rayane-djouah, @MarioExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@rayane-djouah
Copy link
Contributor

Waiting on proposals

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 27, 2024

@RachCHopkins @rayane-djouah @MarioExpensify this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@NJ-2020
Copy link
Contributor

NJ-2020 commented Oct 28, 2024

I cannot reproduce this issue
@rayane-djouah Did you still able to reproduce this issue? Thanks

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
@rayane-djouah
Copy link
Contributor

Let me try reproducing it once more

@melvin-bot melvin-bot bot removed the Overdue label Oct 28, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@MarioExpensify
Copy link
Contributor

@rayane-djouah let us know if this still happens, if not I'll close the issue.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@MarioExpensify MarioExpensify added Weekly KSv2 and removed Daily KSv2 labels Oct 31, 2024
@MarioExpensify
Copy link
Contributor

Changing it to weekly, let's reevaluate next week and if we still can't reproduce we'll close this. Thanks @mvtglobally

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 3, 2024

I can reproduce this issue when i try to login from OD and then got redirected to ND

Screen.Recording.2024-11-01.at.00.18.24.mov

Copy link

melvin-bot bot commented Nov 5, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@MarioExpensify
Copy link
Contributor

Thanks @NJ-2020, I tried the same steps as you documented and now I have no luck trying to reproduce. It seems a pretty specific sequence that is causing the issue. @RachCHopkins do you have any thoughts on this issue?

@RachCHopkins
Copy link
Contributor

@MarioExpensify I have none. I think if we can't repro it consistently let's close it.

@MarioExpensify
Copy link
Contributor

Thanks for your input @RachCHopkins, I'll close it and we may reopen if needed. I just tried it again (both the original post and @NJ-2020) with no luck.

Copy link

melvin-bot bot commented Nov 6, 2024

@RachCHopkins @MarioExpensify Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants