Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid app - Loading skeleton when notification tapped and app is killed state #49964

Open
2 of 6 tasks
m-natarajan opened this issue Oct 1, 2024 · 25 comments
Open
2 of 6 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Oct 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1727449830031979

Action Performed:

  1. Have a long chat with User B
  2. As User A, access the chat on your device so it’s cached and kill the app
  3. As User B, message User A
  4. As User A, tap on the notification for the message.

Expected Result:

The full cached chat should be opened, potentially minus the most recent message.

Actual Result:

A skeleton page loads, indicating the app is reloading the chat from scratch rather than using the cache.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screenshot_20240927-080643

Screenshot_20240927-080656

Screenshot_20240927-080707

screen-20240930-073210.mp4

Profile_trace_for_9.0.41-2.cpuprofile

logs-2024-09-30 14_32_20.691.txt

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021844432440110156078
  • Upwork Job ID: 1844432440110156078
  • Last Price Increase: 2024-10-10
Issue OwnerCurrent Issue Owner: @garrettmknight
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Oct 1, 2024
Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)

Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 1, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@Beamanator
Copy link
Contributor

Maybe we can make this Weekly since it's not reproducible yet?

@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels Oct 2, 2024
@garrettmknight
Copy link
Contributor

One possible fix to this (removing duplicate reconnectapp calls) is out, bumping to see if this is still happening here.

@garrettmknight
Copy link
Contributor

Repro steps updated!

@garrettmknight garrettmknight added Daily KSv2 and removed Weekly KSv2 Needs Reproduction Reproducible steps needed labels Oct 10, 2024
@garrettmknight garrettmknight added AutoAssignerNewDotQuality Used to assign quality issues to engineers and removed AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Oct 10, 2024
Copy link

melvin-bot bot commented Oct 10, 2024

Triggered auto assignment to @stitesExpensify (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 10, 2024
@garrettmknight
Copy link
Contributor

@stitesExpensify reassigning since Alex is going to be OOO until Tuesday. Can you take a look? I'll try to grab logs from my repro in a minute.

@garrettmknight
Copy link
Contributor

Logs/onyx state here

@garrettmknight garrettmknight removed the Weekly KSv2 label Oct 10, 2024
@stitesExpensify
Copy link
Contributor

I don't see any reason that this couldn't at least start as External to see if we can get it fixed by a contributor, so I'm going to start there and see where we end up!

@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Oct 10, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

@garrettmknight, @eVoloshchak, @stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Oct 15, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 23, 2024
@melvin-bot melvin-bot bot changed the title [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state [HOLD for payment 2024-10-30] [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state Oct 23, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 23, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 23, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
  • [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@eVoloshchak] Determine if we should create a regression test for this bug.
  • [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@garrettmknight garrettmknight removed the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 29, 2024
@garrettmknight garrettmknight changed the title [HOLD for payment 2024-10-30] [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state Oct 29, 2024
@garrettmknight
Copy link
Contributor

@kirillzyusko looks like @quinthar is still experiencing:

screen-20241028-132410.mp4

@garrettmknight garrettmknight added Daily KSv2 and removed Weekly KSv2 labels Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

@garrettmknight @eVoloshchak @kirillzyusko @stitesExpensify this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Copy link

melvin-bot bot commented Nov 1, 2024

@garrettmknight, @eVoloshchak, @kirillzyusko, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
@garrettmknight
Copy link
Contributor

garrettmknight commented Nov 1, 2024

Looks like a recent adhoc build is solving this! Let's keep it open till we've deployed and tested on prod, but I'll take over monitoring to keep an eye on the PR.

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2024
@garrettmknight garrettmknight added Weekly KSv2 and removed Daily KSv2 labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: CRITICAL
Development

No branches or pull requests

8 participants