[HOLD for payment 2024-12-03] [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1727449830031979

Action Performed:

1. Have a long chat with User B
2. As User A, access the chat on your device so it’s cached and kill the app
3. As User B, message User A
4. As User A, tap on the notification for the message.

Expected Result:

The full cached chat should be opened, potentially minus the most recent message.

Actual Result:

A skeleton page loads, indicating the app is reloading the chat from scratch rather than using the cache.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

screen-20240930-073210.mp4

Profile_trace_for_9.0.41-2.cpuprofile

logs-2024-09-30 14_32_20.691.txt

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844432440110156078
• Upwork Job ID: 1844432440110156078
• Last Price Increase: 2024-10-10

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[Beamanator]

Maybe we can make this Weekly since it's not reproducible yet?

[garrettmknight]

One possible fix to this (removing duplicate reconnectapp calls) is out, bumping to see if this is still happening here.

[garrettmknight]

Repro steps updated!

[melvin-bot]

Triggered auto assignment to @stitesExpensify (AutoAssignerNewDotQuality)

[garrettmknight]

@stitesExpensify reassigning since Alex is going to be OOO until Tuesday. Can you take a look? I'll try to grab logs from my repro in a minute.

[garrettmknight]

Logs/onyx state here

[Julesssss]

Thanks, PR looks good to me

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use reconnect when starting hybrid app #52824

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @jnowakow does not require payment (Contractor)

[melvin-bot]

@eVoloshchak @garrettmknight @eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $250 via NewDot
• Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@garrettmknight)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1844432440110156078/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[garrettmknight]

@eVoloshchak can you complete the checklist?

[melvin-bot]

@garrettmknight, @eVoloshchak, @Julesssss, @stitesExpensify, @jnowakow Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: [HybridApp] Share auth token in HybridApp #48007
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48007/files#r1877981836
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not sure if additional discussion is needed, this is a simple visual bug

Regression Test Proposal

1. Have a long chat with User B
2. As User A, access the chat on your device so it’s cached and kill the app
3. As User B, message User A
4. As User A, tap on the notification for the message.
5. Observe that there are no loading skeletons for previous messages

Do we agree 👍 or 👎

[garrettmknight]

@eVoloshchak please request from ND.