[$250] QBO-If "Export company card expenses as" is set to "Vendor bill", Locations toggle is locked

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5027294
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Go to workspace settings
3. Connect QBO
4. Tap export
5. Set export company card expense to "vendor bills"
6. Set export out of pocket expense to "journal entry"
7. Navite to import
8. Tap locations -- import

Expected Result:

If "Export company card expenses as" is set to "Vendor bill", the Locations toggle must not be locked

Actual Result:

If "Export company card expenses as" is set to "Vendor bill", the Locations toggle is locked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6622536_1727898934788.Screenrecorder-2024-10-03-01-15-29-585_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843661642289072627
• Upwork Job ID: 1843661642289072627
• Last Price Increase: 2024-10-15

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If "Export company card expenses as" is set to "Vendor bill", the Locations toggle is locked

What is the root cause of that problem?

• The condition canImportLocation is incorrect:

App/src/pages/workspace/accounting/qbo/import/QuickbooksLocationsPage.tsx

Lines 25 to 27 in f475642

	const canImportLocation =
	qboConfig?.reimbursableExpensesExportDestination === CONST.QUICKBOOKS_REIMBURSABLE_ACCOUNT_TYPE.JOURNAL_ENTRY &&
	qboConfig?.nonReimbursableExpensesExportDestination !== CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILL;

What changes do you think we should make in order to solve the problem?

• It should be:

    const canImportLocation =
        qboConfig?.reimbursableExpensesExportDestination === CONST.QUICKBOOKS_REIMBURSABLE_ACCOUNT_TYPE.JOURNAL_ENTRY &&
        qboConfig?.nonReimbursableExpensesExportDestination === CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILL;

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021843661642289072627

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[allgandalf]

Edited by proposal-police: This proposal was edited at 2024-10-08 14:55:26 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Location toggle is locked even when it is allowed on the BE.

What is the root cause of that problem?

We block the location toggle for vendor bills :

App/src/pages/workspace/accounting/qbo/import/QuickbooksLocationsPage.tsx

Lines 25 to 27 in f475642

	const canImportLocation =
	qboConfig?.reimbursableExpensesExportDestination === CONST.QUICKBOOKS_REIMBURSABLE_ACCOUNT_TYPE.JOURNAL_ENTRY &&
	qboConfig?.nonReimbursableExpensesExportDestination !== CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILL;

What changes do you think we should make in order to solve the problem?

If the expected result is to allow the toggle then remove the second condition:

 const canImportLocation = 
     qboConfig?.reimbursableExpensesExportDestination === CONST.QUICKBOOKS_REIMBURSABLE_ACCOUNT_TYPE.JOURNAL_ENTRY 

What alternative solutions did you explore? (Optional)

[allgandalf]

Note

I checked the API response when we set it to vendor bill and the BE accepts this case:

[shubham1206agra]

@allgandalf Can you check the condition on OldDot too?

[allgandalf]

yeah i too had a double guess here, let me check

[allgandalf]

Do you know where we check imports on OD?

Where's import?

[allgandalf]

Not allowed in OD:

[shubham1206agra]

@sonialiap Which behavior is correct here?

[hungvu193]

This seems not an issue according to this docs.

cc @hayata-suenaga since I think you implemented this feature (#41638).

[melvin-bot]

@sonialiap, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[shubham1206agra]

We are waiting for @hayata-suenaga to respond.

[paultsimura]

@hayata-suenaga doesn't work at Expensify anymore. I doubt you'll get a response for this 🤔

[garrettmknight]

@zanyrenney might be able to help out!

[JmillsExpensify]

Pretty sure that vendor bills support locations, so would love to hear from @zanyrenney on which is right.

[allgandalf]

@JmillsExpensify noting here that BE ALLOWS the toggle, so we are only restricting it on the FE. So i guess you're right here:

[zanyrenney]

Hi! This is working as expected and is not a bug for QBO on Collect Workspaces.

Vendor Bills only support importing Locations as a Report Field on QBO. Since we did not build report fields for Collect (we said this was a control feature), Locations on Vendor Bills should be locked.

Pretty sure that vendor bills support locations, so would love to hear from @zanyrenney on which is right.

They do but only as a report field cc @JmillsExpensify

I could have sworn someone was taking on Report Fields as a project for QBO/Xero. I saw a pre-design about it in Control.

[zanyrenney]

Let me get a bit more info from the doc and have a look in Slack for that pre-design.

Hope the answer above helps @shubham1206agra @hungvu193 !

[zanyrenney]

From the Design Doc!

[zanyrenney]

Here is the pre-design on Report Fields support for QBO / Xero that I thought would build this added "Control" functionality atop this QBO project.

Happy to help get this added if not though! cc @dylanexpensify

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

We can close this cc @sonialiap

[melvin-bot]

@sonialiap, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!