Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer - Suggestion list is above the composer when typing @ in multiline text #50373

Open
6 tasks done
IuliiaHerets opened this issue Oct 8, 2024 · 8 comments
Open
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh051001@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to DM.
  3. Enter a few lines in the composer.
  4. Type @ or :sm

Expected Result:

The suggestion modal should appear above @ or :sm when the composer has multiline text.

Actual Result:

The suggestion modal is above the composer instead of above @ or :sm when the composer has multiline text.
On mweb, Android and iOS app, there is big space between the composer and the modal.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6627974_1728363620860.suggestion.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 8, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lakchote
Copy link
Contributor

lakchote commented Oct 8, 2024

Found the blocker it's #41071

cc @eVoloshchak @stitesExpensify @dukenv0307

can you fix this timely or should we revert?

@dukenv0307
Copy link
Contributor

Checking this now.

@dukenv0307
Copy link
Contributor

@lakchote

The suggestion modal is above the composer instead of above @ or :sm when the composer has multiline text

For the first bug, we deiced to not display the suggestion overlap the composer [here]
(#41071 (comment))

On mweb, Android and iOS app, there is big space between the composer and the modal.

Created a PR for the second bug

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Oct 8, 2024
@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Oct 9, 2024
@garrettmknight
Copy link
Contributor

@dukenv0307 are you fixing this in a different PR somewhere?

@dukenv0307
Copy link
Contributor

@garrettmknight My PR is reverted, so this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants