-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-16] Invoices - Balance is cut off when device font size is small #50374
Comments
Triggered auto assignment to @mjasikowski ( |
Triggered auto assignment to @stephanieelliott ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #vip-bills |
ProposalPlease re-state the problem that we are trying to solve in this issue.When the device font size is small, the balance on invoices appears cut off. What is the root cause of that problem?The issue is due to the use of a static font size in the balance component, specifically App/src/components/Balance.tsx Line 16 in f8e7928
Lines 451 to 453 in 672a937
Line 65 in 5b2a329
textHeadline style within the balance component adjusts line height based on screen scale, which in our caseresults in the line height becoming smaller than the font size, causing the text to look cut off.Line 474 in 672a937
Line 113 in 5b2a329
What changes do you think we should make in order to solve the problem?We should modify the Line 113 in 5b2a329
What alternative solutions did you explore? (Optional)We could override the line height to remain at a constant To implement this, we could initialize a new variable |
Checking |
#46813 this PR introduces the invoice balance view and is a part of this deployment |
@rezkiy37 can you take a look? |
Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue. I am the author of this PR (#46813). |
@mjasikowski Can you please assign me this issue since I reviewed the PR? Thanks! |
@allroundexperts done |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-16. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-17. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Hey @allroundexperts can you complete the BZ checklist when you get a sec? |
Payment Summary
BugZero Checklist (@stephanieelliott)
|
Checklist
Regression test
Verify that the balance amount is displayed correctly. Do we 👍 or 👎 ? |
@allroundexperts I would change "Verify that the balance will not be cut off." to "verify the balance amount is displayed correctly". Otherwise seems fine. |
@mjasikowski Updated! |
@mjasikowski, @allroundexperts, @stephanieelliott, @rezkiy37 Eep! 4 days overdue now. Issues have feelings too... |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #46813
Email or phone of affected tester (no customers): applausetester+kh051001@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
The balance will not be cut off.
Actual Result:
The balance is cut off.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6627975_1728363622395.invoice.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @stephanieelliottThe text was updated successfully, but these errors were encountered: