Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for payment 2024-10-16] Public room - "Use the + button to or split an expense." is not consistent and incomplete #50382

Closed
6 tasks done
IuliiaHerets opened this issue Oct 8, 2024 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a public room.
  3. Note that there is no "Use the + button to or split an expense." message.
  4. Navigate to the public room anonymously in incognito window.
  5. Note that there is "Use the + button to or split an expense." message and it is incomplete.

Expected Result:

In Step 3 and 5, the appearance of the message "Use the + button to or split an expense." should be consistent.
The message should be complete.

Actual Result:

In Step 3, the message does not appear after the room is created.
In Step 5, the message only appears after it is visited anonymously.

The message "Use the + button to or split an expense." is also not complete (Use the + button to ..)
The same incomplete message also appears in group chat.
The message does not appear after relogin for public room.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6628034_1728371365845.20241008_150523.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 8, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@thienlnam
Copy link
Contributor

Fixed with this PR #50384

@thienlnam
Copy link
Contributor

This was fixed and CPed. All that's required left here is C+ payment for review to @jayeshmangwani

@thienlnam thienlnam added the Daily KSv2 label Oct 9, 2024
@sonialiap sonialiap changed the title Public room - "Use the + button to or split an expense." is not consistent and incomplete [Hold for payment 2024-10-16] Public room - "Use the + button to or split an expense." is not consistent and incomplete Oct 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@sonialiap
Copy link
Contributor

not overdue, payment on Wednesday

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2024
@sonialiap
Copy link
Contributor

Payment summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants