-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] VBA - Continue modal is not shown after several attempts #50422
Comments
Triggered auto assignment to @marcochavezf ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Seems this issue stems from this PR. Given that PR fixed a crash and this workflow is not common, I wouldn't consider it a deploy blocker, but it would still require a fix cc @koko57 @mountiny @grgia @DylanDylann Feel free to take it over since you have more context than I do :) |
Job added to Upwork: https://www.upwork.com/jobs/~021843708220772796908 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@koko57 @DylanDylann can you please have a look? thanks! |
@mountiny ok I will look into this today, you can assign me 🙂 |
I haven't much time to look into this one yet, I'll try to check it today but even so I probably won't be able to fix it till EOD. Probably there is some problem with setting state, maybe also a problem with updating the data in Onyx. While working on the original issue (with the crash) I was wondering if we should change this continue modal and the start page (with manual/plaid connection choice and the image) into a separate step - we need to display one of them always anyway. |
Thanks for the insights, this is a niche bug so we can take time to get back to this |
@koko57, @mountiny, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick! |
This is a lower priority |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.46-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #49687
Action Performed:
Precondition: user has several workspaces, e.g. A, B, C
Expected Result:
On step 5, starting page of VBA with setup types displayed
On step 6, Continue page with options 'Continue' and 'Start over' displayed
Actual Result:
On step 5, starting page of VBA with setup types displayed
On step 6, after several attempts, user is navigated to Personal info step he left on step 4
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6628321_1728391481784.vba_fail.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @fedirjhThe text was updated successfully, but these errors were encountered: