Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-25] [Direct Feeds] [App] Adding Direct Card Feed: Amex direct feeds #50449

Closed
mountiny opened this issue Oct 8, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 8, 2024

This is part of the Third party workspace feeds V2 (direct connections) project.

Implement changes from this section of the design doc.

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 8, 2024
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 8, 2024
@narefyev91
Copy link
Contributor

Hi, I'm Nicolay from Callstack - expert agency - and I would like to work on this issue.

@allgandalf
Copy link
Contributor

@narefyev91 when can we expect the PR, lets get rock and rolling 🎸

@mountiny mountiny changed the title [Direct Feeds] [App] Adding Direct Card Feed: Selecting feed type [Direct Feeds] [App] Adding Direct Card Feed: Amex direct feeds Oct 10, 2024
@allgandalf
Copy link
Contributor

@narefyev91 any update here ?

@narefyev91
Copy link
Contributor

WIP for this one

@narefyev91
Copy link
Contributor

waiting just this one to be merge to open PR for amex #50602

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 15, 2024
@allgandalf
Copy link
Contributor

♻️ PR was merged

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 18, 2024
@melvin-bot melvin-bot bot changed the title [Direct Feeds] [App] Adding Direct Card Feed: Amex direct feeds [HOLD for payment 2024-10-25] [Direct Feeds] [App] Adding Direct Card Feed: Amex direct feeds Oct 18, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 18, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allgandalf] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@dylanexpensify dylanexpensify moved this to Hold for Payment in [#whatsnext] #expense Oct 18, 2024
@allgandalf
Copy link
Contributor

Let's close this @mountiny

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants