[HOLD for payment 2025-01-02] [$250] Android - Crash when kill the app and reopen it

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a2536@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Install the New dot app
2. Open android app
3. Login with new gmail account
4. Complete the onboarding modal
5. Kill the app
6. Open the app

Expected Result:

App should open

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6628394_1728395962594.Recording__4245.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843775413325774813
• Upwork Job ID: 1843775413325774813
• Last Price Increase: 2024-11-19
• Automatic offers:
• DylanDylann | Reviewer | 105060601
• shubham1206agra | Contributor | 105341816

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[srikarparsi]

Not able to reproduce on my physical ios device with a new account. Going to try on android emulator.

[thienlnam]

There's been an emerging crash in firebase that looks like it might be related here
com.expensify.chat_issue_4f8a216f0a769e684d009b28ef9bd7d4_crash_session_6705473302F5000179E748FD60E92734_DNE_0_v2_stacktrace.txt

SurfaceMountingManager.getViewState

Appears to be present in a few different versions, so maybe not a deploy blocker

[thienlnam]

Potentially related: facebook/react-native#38743

[thienlnam]

@kirillzyusko Do you think this #37891 would address this crash as well?

[srikarparsi]

I'm not able to reproduce on an emulator in production
https://github.com/user-attachments/assets/7a55635c-6cfa-4014-8dc1-3d6b43938a9d

[srikarparsi]

I am able to reproduce on staging. But reopening the app does work so it doesn't continually crash. Future quit/reopens don't crash the app either.
https://github.com/user-attachments/assets/ca340a7e-ccd4-417d-93d6-916f02cd59a8

[thienlnam]

Hmm, this crash has been happening quite a bit - perhaps we can get some eyes on this?

[melvin-bot]

Current assignee @srikarparsi is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021843775413325774813

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

@j-piasecki, @srikarparsi, @kadiealexander, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[shubham1206agra]

@srikarparsi Please assign me for review

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Fix CREATE mutations being dropped by merging transactions #53313

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @j-piasecki does not require payment (Contractor)
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

@shubham1206agra @kadiealexander @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[shubham1206agra]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: RN bug

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: NA since the mistake is in RN implementation, not App implementation.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

No test is needed since it was a deploy blocker, and the test is already present in Test Rail.

Do we agree 👍 or 👎

[kadiealexander]

@shubham1206agra could you please accept the Upwork contract?

[melvin-bot]

@j-piasecki, @srikarparsi, @shubham1206agra, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[shubham1206agra]

@kadiealexander Offer accepted