[Search v2.1] -"Hmm... it's not here" briefly appears after re-signing in via search URL

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.47-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+tw435353535333@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Sign in to the staging environment of Expensify and navigate to the search page.
2. Copy the URL of the search page.
3. Go to Account Settings and sign out.
4. Paste the copied URL into the browser and press enter.
5. Sign in again and observe the behavior.

Expected Result:

After signing in, the search page should appear directly after a loading animation, without briefly displaying the "Hmm... it's not here" message.

Actual Result:

The "Hmm... it's not here" page is briefly displayed before the search page loads when signing in through the search URL.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6630510_1728551793009.Screen_Recording_2024-10-10_at_1.49.16_AM.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[Julesssss]

THis isn't a blocker, checking off the list.

FYI @luacmartins.

[luacmartins]

cc @adamgrzybowski @WojtekBoman it seems like we are redirected to https://staging.new.expensify.com/Search_Bottom_Tab?q=type%3Aexpense%20status%3Aall%20sortBy%3Adate%20sortOrder%3Adesc when this happens and we fail to parse the query:

SearchUtils.ts:548 Error when parsing SearchQuery: "undefined" TypeError: Cannot read properties of undefined (reading 'charAt')
    at et (searchParser.js:1097:16)
    at We (searchParser.js:473:10)
    at searchParser.js:1140:16
    at Object.qe (SearchUtils.ts:539:24)
    at da (SearchPageBottomTab.tsx:63:25)
    at fo (react-dom.production.min.js:160:137)
    at vA (react-dom.production.min.js:289:337)
    at Il (react-dom.production.min.js:279:389)
    at ml (react-dom.production.min.js:279:362)
    at al (react-dom.production.min.js:267:300)

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Make it load without "Hmm... it's not here" when re-singing in via search URL

What is the root cause of that problem?

The SCREENS.ts BOTTOM_TAB is redirecting to 'Search_Bottom_Tab' but what we pasted on the search url is only 'search'

What changes do you think we should make in order to solve the problem?

Edit the search BOTTOM_TAB on the SCREENS.ts from
BOTTOM_TAB: 'Search_Bottom_Tab',
to
BOTTOM_TAB: 'search',

What alternative solutions did you explore? (Optional)

[WojtekBoman]

Does this error still occur or are there any additional conditions to perform to reproduce this? I tested it locally and on staging and it seems to work well. A pop-up window appears in the video attached in the issue description and at this point we can see the error, perhaps it's a precondition to reproduce that.

Screen.Recording.2024-10-11.at.08.27.07.mp4

[luacmartins]

@WojtekBoman not sure. I was able to reproduce once yesterday with the steps in the OP. Let me try again.

[luacmartins]

Hmm just tried to reproduce now and I also couldn't. @IuliiaHerets could you please re-test?

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Weird, shouldn't be overdue, it's weekly and was posted on 3 days ago, awaiting retest.