Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-29] [Wave Control] [QBD] Restrict QBD to Control plans #50704

Closed
lakchote opened this issue Oct 14, 2024 · 21 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lakchote
Copy link
Contributor

We need to show QBD in the policy's accounting page for Control plans only.

@kadiealexander
Copy link
Contributor

@jamesdeanexpensify do you have any copy suggestion for what should show in the QBD equivalent of this?

image

@jamesdeanexpensify
Copy link
Contributor

I would probably just substitute "QuickBooks Desktop" in for "Sage Intacct" and then...what minimal tweaks can we make to that sentence that starts "Gain in-depth..." to make it accurate for QBD? Like what are the most valuable selling points?

@kadiealexander
Copy link
Contributor

kadiealexander commented Oct 14, 2024

I think our most valuable selling point is that it's the only two-way automated QBD connector on the market right now. There isn't really anything unique like user-defined dimensions or custom segments to call out. Does it need to be in depth?

Maybe something like:

Enjoy automated syncing and reduce manual entries with the Expensify + QuickBooks Desktop integration. Gain ultimate efficiency with a realtime, two-way connection and expense coding by class, item, customer, and project.

@jamesdeanexpensify
Copy link
Contributor

Edited your comment a bit, but that sounds good! Can we see how that looks mocked up?

@kadiealexander
Copy link
Contributor

kadiealexander commented Oct 14, 2024

Sure can!

image

It's here in Figma if anyone wants to play around!

@jamesdeanexpensify
Copy link
Contributor

Just made one edit but the Figma now looks good!

@kadiealexander
Copy link
Contributor

Updated my screenshot above, thanks James!! @lakchote let me know if you need anything else from us.

@lakchote
Copy link
Contributor Author

Thank you both @jamesdeanexpensify @kadiealexander that's good for me!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 16, 2024
@melvin-bot melvin-bot bot changed the title [Wave Control] [QBD] Restrict QBD to Control plans [HOLD for payment 2024-10-29] [Wave Control] [QBD] Restrict QBD to Control plans Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 28, 2024
@lakchote lakchote added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lakchote lakchote removed the Bug Something is broken. Auto assigns a BugZero manager. label Oct 29, 2024
@trjExpensify
Copy link
Contributor

What's the dealio here? Standard payment issue? New feature and a regression test will be added for it when the tests are passed over to Applause centrally?

Copy link

melvin-bot bot commented Oct 29, 2024

Payment Summary

Upwork Job

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@hoangzinh
Copy link
Contributor

Regression Test Proposal

Prerequisites:

  • Turn on Beta quickbooksDesktopOnNewDot on your account
  • Create a workspace with the Collect plan
  1. Sign in on an account above
  2. Go to the collect Workspace above -> Accounting
  3. Click on Connect under QuickBooks Desktop connection
  4. Verify that it displays upgrade your workspace to the Control plan page

Do we agree 👍 or 👎

@hoangzinh
Copy link
Contributor

What's the dealio here? Standard payment issue? New feature and a regression test will be added for it when the tests are passed over to Applause centrally?

Yes, @trjExpensify.

@lakchote
Copy link
Contributor Author

What's the dealio here? Standard payment issue? New feature and a regression test will be added for it when the tests are passed over to Applause centrally?

It's a standard payment issue. The manual test steps document with all the regression tests has already been done yesterday.

@trjExpensify
Copy link
Contributor

Okay great, I see the upgrade is included in that doc handed over. Thanks!

Payment summary as follows:

  • $250 to @hoangzinh for the C+ review (go ahead and request!)
  • $250 to @ZhenjaHorbach for the implementation (offer sent!)

@hoangzinh
Copy link
Contributor

Requested payment in ND

@trjExpensify
Copy link
Contributor

Paid @ZhenjaHorbach, closing!

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

@trjExpensify @lakchote Be sure to fill out the Contact List!

@garrettmknight
Copy link
Contributor

$250 approved for @hoangzinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

7 participants