You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ReportPreview Avatar code depends on BE or FE data depending on the report type. This has resulted in avatars and report preview headers breaking frequently.
The logic was nearly solved by this PR - #49172 which changed the logic to use the ownerID for reportPreviews as well as adding a calculation for This worked for all cases except the Send Money Flow where the ownerID is the payee, which is not the original actor.
Solution:
Define the rules for avatars as below and have design check them off
Define what data we need for avatars and send it in the reportpreview object (similar to how we send childReportActorID)
Send the avatar data from the BE and use that for the report preview case
Use this flow to create a UI-based test rail for these avatars / headers to prevent future regressions
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Context
The ReportPreview Avatar code depends on BE or FE data depending on the report type. This has resulted in avatars and report preview headers breaking frequently.
The logic was nearly solved by this PR - #49172 which changed the logic to use the ownerID for reportPreviews as well as adding a calculation for This worked for all cases except the Send Money Flow where the ownerID is the payee, which is not the original actor.
Solution:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: