Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR Phase 3] Step 3 - navigation, default data, logic and API call to save it #50905

Open
madmax330 opened this issue Oct 16, 2024 · 5 comments
Assignees
Labels

Comments

@madmax330
Copy link
Contributor

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.o63v6yk67yf5

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Nov 14, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Nov 21, 2024

Implementation is ongoing. Waiting on more details regarding one of the fields and implementation of the API.

Apart from that, step 2 logic (#50898) has to be implemented so we can fully test this issue

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Dec 16, 2024

In order to finish this issue the following needs to happen:

  • feat: Update corpay fields logic, integrate API #52812 has to get merged (Step 1 & 2 logic). This creates bankAccountID which is needed to proceed in next steps
  • Data send in Step 2 has to be saved somewhere in onyx. At the moment it's not and we cannot access the bankAccountID returned from Step 2. It should be saved inside reimbursementAccount together with all the data saved in Steps 1 & 2.
  • Need a final decision on picklists in Step 3. There is a picklist called Trade volume range. It is not on designs and I haven't got a final decision if we should add it or not. If we have to add it then more directions, labels and translations are needed

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Dec 20, 2024

I will be OOO from 21.12 - 06.01. Latest update for this issue:

  • new picklist has been added
  • testing recordings have been added
  • It is still waiting on feat: Update corpay fields logic, integrate API #52812 to get merged, however it is rebased with latest changes and was kept up to date
  • BE update is still needed - Data send in Step 2 has to be saved somewhere in onyx. At the moment it's not and we cannot access the bankAccountID returned from Step 2. It should be saved inside reimbursementAccount together with all the data saved in Steps 1 & 2. I believe only minor changes will be needed - reading default values when user goes back to this step

@hungvu193
Copy link
Contributor

#52812 is now merge. We can continue with your draft PR when you're back @MrMuzyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants