Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes when switching workspace from workspace switcher #51005

Closed
1 of 8 tasks
MonilBhavsar opened this issue Oct 17, 2024 · 14 comments
Closed
1 of 8 tasks

App crashes when switching workspace from workspace switcher #51005

MonilBhavsar opened this issue Oct 17, 2024 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Oct 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Coming from https://expensify.slack.com/archives/C049HHMV9SM/p1729164622564699
Version Number: v9.0.50-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MonilBhavsar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729164622564699

Action Performed:

Break down in numbered steps

  1. Have a high traffic account with few workspaces and reports
  2. Try to switch the workspace from the workspace and notice app crashes

Expected Result:

Describe what you think should've happened
App should not crash and workspace should be switched

Actual Result:

Describe what actually happened
App crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence Screenshot 2024-10-17 at 4 37 55 PM

View all open jobs on GitHub

@MonilBhavsar MonilBhavsar added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 17, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 17, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MarioExpensify
Copy link
Contributor

👀 into it. @MonilBhavsar do you have any sample account you can share so I can reproduce the issue?

@MonilBhavsar
Copy link
Contributor Author

It happens on my test account - monil+2@expensifail.com

@MonilBhavsar
Copy link
Contributor Author

I think this has something to do with switching between #focus and most recent mode.

I was seeing the crash consistently on each click. I am now trying to get it back by -

  1. Switch to #focus mode and logout
  2. Signin again so very limited reports are fetched
  3. Switch workspace

Currently, I see "Hmm, it's not there page" but not crash

@MonilBhavsar
Copy link
Contributor Author

I am now seeing infinite loaders :/
Could anyone please try these steps ^

@MarioExpensify
Copy link
Contributor

I think this has something to do with switching between #focus and most recent mode.

I was seeing the crash consistently on each click. I am now trying to get it back by -

  1. Switch to #focus mode and logout
  2. Signin again so very limited reports are fetched
  3. Switch workspace

Currently, I see "Hmm, it's not there page" but not crash

I tried the above steps with my own Expensify account, I could not crash nor see infinite loaders, but it got stuck in focus mode (didn't load the rest of the chats when changed the mode to most recent). I had to logout and log back in to see everything back.

@MonilBhavsar
Copy link
Contributor Author

MonilBhavsar commented Oct 17, 2024

Weird. I tried a lot but could not see a crash
I think we can demote from blocker if no one else is able to reproduce crasg. sorry for false alarm

Btw, I still see infinite loading everywhere and broken URL

Screen.Recording.2024-10-17.at.6.17.10.PM.mov

@trjExpensify
Copy link
Contributor

What are we doing with this issue then?

Btw, I still see infinite loading everywhere and broken URL

Is that being looked into somewhere else?

@MarioExpensify
Copy link
Contributor

I just got a Hight Traffic account following this SO, still cannot reproduce the issue in Staging (neither the crash nor the fail to load). Is there any other step we can go through before discarding this as a DeployBlocker? Just making sure I'm not forgetting any step and possibly causing some issues down the road @trjExpensify @MonilBhavsar

@trjExpensify
Copy link
Contributor

Nope, just the ones in the SO: https://stackoverflowteams.com/c/expensify/questions/9980

@MarioExpensify
Copy link
Contributor

Okay, thank you @trjExpensify, closing this one as specified in the SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants