[HOLD for payment 2024-10-30] De-dupe OpenReport requests

[mountiny]

similarly to this issue for OpenApp #50076

Problem

We are seeing some scenarios where multiple OpenReport requests are serialized in a row. When multiple such requests are sent, it's redundant, slows down the app, and contributes to server traffic.

Solution

De-dupe OpenReport requests for the same reportId such that only one can be serialized at a time.

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gedu]

Hey, I'm Edu from Callstack, I can work on it

[eh2077]

@mountiny Can I get assigned here? So we can track the payment, thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Replace duplicated openReports #51093

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @gedu does not require payment (Contractor)
• @eh2077 requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eh2077] Determine if we should create a regression test for this bug.
• [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

@eh2077 can you please complete the checklist? I think we do not need regression tests for this as we added unit tests

[eh2077]

Checklist

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR: This is an improvement, so there isn't a PR causes this bug.

TL;DR
Digging into the commit history, we have pursued this improvement for some time. Below are the timeline

1. A de-dupe logic was first introduced to solve this issue Create generic network layer logic for conflicting write requests #39024
2. The de-dupe logic was reverted Remove all request de-duping logic #40180 to pursue better solution
3. Then De-dupe ReconnectApp in the persisted requests queue #47913 was merged
4. This PR can be considered as a follow-up PR of De-dupe ReconnectApp in the persisted requests queue #47913

• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@eh2077] Determine if we should create a regression test for this bug. No, because this improvement is implicit and doesn't impact the flow to use the App.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @gedu is from an agency-contributor and not due payment
• Reviewer: @eh2077 owed $250 via NewDot

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[strepanier03]

Payment Summary

• @gedu does not require payment (Contractor)
• $250 - @eh2077 via payment through NewDot Manual Requests

[strepanier03]

@eh2077 - feel free to request payment now. Cheers!

[eh2077]

Requested in NewDot

[JmillsExpensify]

$250 approved for @eh2077