-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search-Search result shows fallback avatar and email instead of custom avatar and display name #51123
Comments
Triggered auto assignment to @isabelastisser ( |
Triggered auto assignment to @MarioExpensify ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Hey, I was responsible for the accused PR. Feel free to assign this to me I can look into it today! |
Hm, i can neither reproduce this on staging or latest dev commit: Screen.Recording.2024-10-21.at.10.18.47.movThe PR hasn't changed anything about how we display search results, it just changed how we filter for them. So i am not really sure if the PR could've caused such behaviour. |
Retest requested. Just making sure before moving forward. |
Still reproducible on staging Recording.2867.mp4Recording.2868.mp4 |
Hey @hannojg, mind taking another look? I looked through other PRs and did not find any other that may be the cause for this issue. Feel free to reach me out if you think it is unrelated to your latest changes. |
That PR was reverted it seems. @MarioExpensify assigning myself since I merged that PR, but feel free to stay assigned. |
@hannojg @isabelastisser @marcaaron this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Guys sorry, this completely slipped past me! I will take another look at that one this week! (If this is related to the mentioned PR, it currently shouldn't be reproducible on either staging on prod, as the PR has been reverted. I am working on a new PR, and will keep this bug in mind this time.) |
Okay, so after investigating this, this isn't a problem with the PR originally mentioned: The problem seems to be that sometimes you get a 407 error for the search query, thus we are not getting any data from the backend: We can see from the screenshot that the network command for the search was fired before the user got re-authenticated. I originally got assigned to this issue because it was suspected that my PR caused this issue - which it didn't. Our team (margelo) can look into the issue if you like, or you can make it external i think. |
@hannojg, thanks for the update! Can you please continue to work on this issue? Thanks! |
@chrispader can you comment here? Chris from the Margelo team will work on a fix for this ticket (as i am very busy with other tasks rn). |
commenting for assignment :) |
hey @chrispader, I just assigned you. Thanks! |
@chrispader do you have an update for this one? My understanding is that the |
Hey @chrispader, can you please follow up on the questions above? Thanks! |
Hey so sorry for the massive delay! I was totally busy on another PR and should have looked into this way earlier! 🫠 I investigated the problem and can clearly reproduce the problem for a particular set of accounts/email addresses. ProblemThe problem essentially is that the response received from the backend for If no Because the logic couldn't find any personal details item, we will just add a "blank" options list item to the options list and therefore the default avatar is used. SolutionBecause of this i would argue that this is a backend issue and the Backend responses for different accounts/email addresses and Onyx DB screenshot
|
I don't think it is on purpose, that the backend doesn't send a Or am i missing something here? |
AFAICT there's really only one case where we would not return a There is a property called I think this feature is working as intended. @puneetlath worked on this and can give a second opinion. But my guess for this issue based on the evidence provided is that we didn't make the connection to |
That sounds correct to me. You should get the full personal details, including login, when you "know" someone. You should get the partial personal details when you don't. |
Ok i understand. Does that mean, that since we don't receive these infos, we also don't want to show things like the avatar? Without the email, address we cannot really match it with the search input... e.g. when i'm searching for an email address of a user i "don't know", e.g. "yonghongkok2@gmail.com", we receive the missing data like avatar and name from the |
I think what is being reported is probably fine and we should close this out (but seems like it could reopen again as a suspected bug). We could maybe improve the UX so that "not known" users show up with a |
Closing this! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #48652
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The search result will show user with custom avatar and display name.
Actual Result:
The search result shows user with fallback avatar and email address as display name instead of custom avatar and custom display name.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6639700_1729346685510.bandicam_2024-10-19_22-01-20-118.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: