Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-07] [HOLD for payment 2024-11-05] E2E: Don't fail whole e2e test suite when one test fails #51154

Closed
hannojg opened this issue Oct 21, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@hannojg
Copy link
Contributor

hannojg commented Oct 21, 2024

Currently in the e2e testing pipeline if one test fails the whole test suite is failed. Instead the test suite should always complete, and failed test cases should be reported individually.

This has been discussed in here (in the #e2e-announce channel).

Notes:

  • for each completely failed test case we should send a individual slack notification
  • failed tests should be marked in the report as failed
  • if a test failed in the test suite we should comment the report to the PR against which the test suite was executed, noting that a certain test is broken
    • If a test is broken on main and merged PRs after that would have this test as failed. we should add a note in the github comment that its possible that the test has been broken in a previous PR and that the author can check the commits on main to see if this PR's commit was the first failed one. This can help avoid confusion for PR authors
Issue OwnerCurrent Issue Owner: @kirillzyusko
@hannojg
Copy link
Contributor Author

hannojg commented Oct 21, 2024

cc @mountiny and @kirillzyusko and @chrispader (i remember one of the two was available to work on this ticket)

@mountiny mountiny self-assigned this Oct 21, 2024
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@mountiny
Copy link
Contributor

Thanks! Please comment on this issue whoever will work on this

Copy link

melvin-bot bot commented Oct 21, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@dubielzyk-expensify
Copy link
Contributor

Assuming you don't need design help here?

@kirillzyusko
Copy link
Contributor

I can handle this @mountiny 🙌

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 23, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 23, 2024
@melvin-bot melvin-bot bot changed the title E2E: Don't fail whole e2e test suite when one test fails [HOLD for payment 2024-11-05] E2E: Don't fail whole e2e test suite when one test fails Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@kirillzyusko] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mountiny
Copy link
Contributor

No regression tests or payments required for this. Updating the e2e test suite

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 31, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-05] E2E: Don't fail whole e2e test suite when one test fails [HOLD for payment 2024-11-07] [HOLD for payment 2024-11-05] E2E: Don't fail whole e2e test suite when one test fails Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@kirillzyusko] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@mountiny
Copy link
Contributor

mountiny commented Nov 1, 2024

I believe we can close this one, updating the e2e test suite, no regression tests required

@mountiny mountiny closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants