[HOLD for payment 2024-11-13] [$250] Tags - App returns to tag page after tapping back button on workspace editor

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.53-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5123688
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace has imported dependent tags (attached below).

1. Launch ND or hybrid app.
2. Go to workspace settings > Tags.
3. Tap on any main tag.
4. Tap app back button to go back to main tag page.
5. Tap app back button to return to workspace editor.
6. Tap app back button again.

Expected Result:

App will return to workspace list

Actual Result:

App returns to tag page after tapping back button on workspace editor.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6644449_1729774664725.iOS.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849826177749803490
• Upwork Job ID: 1849826177749803490
• Last Price Increase: 2024-10-25

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[Julesssss]

Regression, but not a blocker. Removing label.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - App returns to tag page after tapping back button on workspace editor

What is the root cause of that problem?

We pass fallback route when going back which push new stack navigator

App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

Line 276 in 66112d1

Navigation.goBack(isQuickSettingsFlow ? ROUTES.SETTINGS_TAGS_ROOT.getRoute(policyID) : ROUTES.WORKSPACE_TAGS.getRoute(policyID));

What changes do you think we should make in order to solve the problem?

We should remove the fallback route

What alternative solutions did you explore? (Optional)

We can can pass backTo as the fallback route

Navigation.goBack(backTo)

[kadiealexander]

Reassigning as I'm OOO for the next two weeks.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849826177749803490

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app gets stuck on the same page after we click the back button.

What is the root cause of that problem?

I believe it has the exact same root cause as this issue: #50695
The issue stems from this code:

App/src/libs/Navigation/linkTo/index.ts

Lines 120 to 127 in 9508b17

	// If the type is UP, we deeplinked into one of the RHP flows and we want to replace the current screen with the previous one in the flow
	// and at the same time we want the back button to go to the page we were before the deeplink
	} else if (type === CONST.NAVIGATION.TYPE.UP) {
	if (!areParamsDifferent && isSideModalNavigator(lastRoute?.name) && topmostCentralPaneRoute?.name === targetName) {
	dismissModal(navigation);
	return;
	}
	action.type = CONST.NAVIGATION.ACTION_TYPE.REPLACE;

1. We attempt to replace the current RHP (Right Hand Panel) screen with the fallback/backTo route (Tags page in this issue)
2. The replace operation correctly sets the "Tags page" as the current route
3. However, the Tags route already exists in our route stack at routes.at(-2)
4. When we perform the replace operation, we end up with duplicate Tags page routes:
   1. One from the existing stack
   2. Another from the replace operation

What changes do you think we should make in order to solve the problem?

To resolve this issue and similar ones, we can change code to use navigate instead of replace when the RHP closes: Here

action.type = CONST.NAVIGATION.ACTION_TYPE.NAVIGATE;
This change will allow us to navigate to the existing fallback route without creating a duplicate. It brings the Tags page to the front of the stack while removing the current route.

Screen.Recording.2024-10-28.at.4.59.02.AM.mov

[ntdiary]

Origin PR update: #50416 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix]: App returns to tag page after tapping back button on workspace editor #51568

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment through NewDot Manual Requests

[melvin-bot]

@ntdiary @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ntdiary]

I didn't review PR #51568, so no need to include me in the payment. 😄

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @ntdiary owed $250 via NewDot

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1849826177749803490/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[isabelastisser]

@Julesssss, was this an internal issue? It looks like no external contributor was involved.

[Julesssss]

Hey, it looks like @twilight2294 was the PR author, and @paultsimura was the C+ reviewer.

[paultsimura]

Hi, this one was a follow-up, so it can be closed without a payment.

[Julesssss]

Aha, thank you!