[HOLD for payment 2024-12-20] [$250] Search - Hmm it's not here opens when try to View invoices created in OD

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3284914
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: workspace with enabled invoices. Admin is logged in ND and OD

1. In OD: Submit a invoice to anyone with at least 2 expenses
2. In ND: Navigate to the Search page
3. Click on Invoices
4. Click on the Outstanding filter
5. Click on the “View” button next to the report that has the 2 expenses grouped

Expected Result:

The report view is displayed and the 2 expenses are visible

Actual Result:

'Hmm.. it's not here' tab is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6646569_1729938456638.invoice_tab_hmm.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851097781495138249
• Upwork Job ID: 1851097781495138249
• Last Price Increase: 2024-11-12
• Automatic offers:
• dukenv0307 | Reviewer | 104892930

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-bills

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851097781495138249

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[VictoriaExpensify]

I think since this is a backward compatible issue, I would put this as a Migrate bug. But we should definitely get this fixed

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[rezkiy37]

I am OOO till Tuesday and will continue to work on this issue later.

[melvin-bot]

@VictoriaExpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[VictoriaExpensify]

Not OD

[rezkiy37]

I am back and working on the issue.

[rezkiy37]

I can confirm the bug is replicable. Working on it.

Details

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@VictoriaExpensify, @dukenv0307 Still overdue 6 days?! Let's take care of this!

[rezkiy37]

Working on the issue.

[rezkiy37]

I've started a discussion in Slack.

[melvin-bot]

@VictoriaExpensify, @dukenv0307 12 days overdue now... This issue's end is nigh!

[rezkiy37]

Working on the issue.

[VictoriaExpensify]

Any updates on this @cristipaval ?

[cristipaval]

The backend PR is ready for review.

[cristipaval]

@rezkiy37, the backend PR has been deployed

[rezkiy37]

Hey @cristipaval!
I can confirm that the backend allows the app to render reports now. Thank you!

However, I just tested it and found that there is a crucial difference between normal invoice rooms and invoices with multiple expenses. They are not defined as invoice rooms or invoice reports but they are policy expense reports.

Screenshots

Invoice room

Invoice report actions

Invoice report

Does it make sense?

[cristipaval]

Hey @rezkiy37!

The invoice report should be rendered similarly to an expense report, not to an invoice room or expense chat. So you should get the report.type = invoice

[cristipaval]

I added more clarification here. Let me know if you still need changes in the backend

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow invoices with multiple expenses #52556

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot]

@dukenv0307 @VictoriaExpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Need both BE and FE fix

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

Precondition: have a workspace with enabled invoices. Admin is logged in ND and OD.

1. In OD: Submit a invoice to anyone with at least 2 expenses.
2. In ND: Navigate to the Search page.
3. Click on Invoices.
4. Click on the "Outstanding" filter.
5. Click on the “View” button next to the report that has the 2 expenses grouped.
6. Verify the the report view is displayed and the 2 expenses are visible.

Do we agree 👍 or 👎

[VictoriaExpensify]

Created request to add regression test to testrail https://github.com/Expensify/Expensify/issues/455488

[VictoriaExpensify]

Payment summary:
C: @rezkiy37 - Contractor
C+: @dukenv0307 paid $250 via Upwork