Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members- Refresh while on the WS invite message page empty show invite message again #51655

Open
1 of 8 tasks
lanitochka17 opened this issue Oct 29, 2024 · 3 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Overdue

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.55-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #51228

Action Performed:

  1. Open the WS invite page
  2. Select any user and go next
  3. Empty the message
  4. Refresh the page

Expected Result:

Refresh while on the WS invite message page with empty message should show message place empty as it was before refreshed

Actual Result:

Refresh while on the WS invite message page empty show invite message all over again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6649184_1730199210689.Screen_Recording_20241029_133649_Chrome.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@FitseTLT
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Members- Refresh while on the WS invite message page empty show invite message again

What is the root cause of that problem?

We are using || here to get the default message so as empty string is falsy it will load the default message

workspaceInviteMessageDraft ||

What changes do you think we should make in order to solve the problem?

We should use ?? instead

            workspaceInviteMessageDraft ??

and then we should make sure the draft is always reset whenever the user navigates to invite message page

Member.setWorkspaceInviteMembersDraft(route.params.policyID, invitedEmailsToAccountIDs);

        Policy.setWorkspaceInviteMessageDraft(route.params.policyID, null);

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Overdue
Projects
None yet
Development

No branches or pull requests

3 participants