Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding - Error occurs when marking a task as complete #51969

Closed
1 of 8 tasks
lanitochka17 opened this issue Nov 4, 2024 · 10 comments
Closed
1 of 8 tasks

Onboarding - Error occurs when marking a task as complete #51969

lanitochka17 opened this issue Nov 4, 2024 · 10 comments
Assignees
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.57-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): htad26+fgfgfjhgf@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #51722

Action Performed:

  1. Sign in with new account
  2. On the onboarding flow, select "Chat and split expenses with friends" > Enter a name and finish the flow
  3. In the concierge chat, click on any of the tasks
  4. Click on "Mark as complete"

Expected Result:

The task is marked as complete

Actual Result:

"You don't have permission to take the requested action." error occurs

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6654468_1730737061762.2024-11-04_19_10_48.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 4, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@danieldoglas
Copy link
Contributor

hmm @deetergp looks like the permissions are not correctly set for the new tasks being created? I think it's related to https://github.com/Expensify/Auth/pull/12835

@danieldoglas
Copy link
Contributor

cc @francoisl too

@trjExpensify
Copy link
Contributor

Scott is out until tomorrow btw.

@danieldoglas
Copy link
Contributor

This is a backend issue, so I don't think we need to block the app on it. do you agree, @trjExpensify @francoisl ?

@francoisl
Copy link
Contributor

Yes agreed.

@francoisl francoisl added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 4, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 4, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

This issue has not been updated in over 15 days. @danieldoglas eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 28, 2024
@danieldoglas
Copy link
Contributor

I think this one is finished. @francoisl did all the work on the backend. Assigning him and closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants