-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS / Android - Request money page breaks after using 14 digits #5241
Comments
Triggered auto assignment to @ctkochan22 ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
I feel like the simplest fix would be to cap the size of the amount you can enter to 10 digits? I think that's the max we allow in the backend anyway. |
Oh haha I just realized the original PR was to cap the amount to 14 digits. I checked that our backend only allows for 10 digits, so 14 wouldn't have worked anyway. |
@francoisl Ohh this never came up in any previous discussions XD. Sure I'll add a cap of 10 digits. |
🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀
|
I think we're good to close this one out CC @francoisl |
🚀 Deployed to staging by @francoisl in version: 1.0.98-2 🚀
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue is failing PR #5192 (CC @akshayasalvi @marcaaron @deetergp)
Action Performed
Expected Result
Request money page looks properly aligned after using 14 digits
Actual Result
Request money page breaks after using 14 digits
Platform
iOS ✔️
Android ✔️
Version Number: 1.0.98-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Images/Video
Bug5235387_Screen_Recording_20210913-171127_New_Expensify.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: