Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS / Android - Request money page breaks after using 14 digits #5241

Closed
isagoico opened this issue Sep 14, 2021 · 8 comments
Closed

iOS / Android - Request money page breaks after using 14 digits #5241

isagoico opened this issue Sep 14, 2021 · 8 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@isagoico
Copy link

isagoico commented Sep 14, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue is failing PR #5192 (CC @akshayasalvi @marcaaron @deetergp)

Action Performed

  1. Launch the app and log in with any account
  2. Go to any transaction option - Split Money or Request Money
  3. Search for ALL currency
  4. Go to the number pad and try to type a very long number - say 14+ digits.

Expected Result

Request money page looks properly aligned after using 14 digits

Actual Result

Request money page breaks after using 14 digits

Platform

iOS ✔️
Android ✔️

Version Number: 1.0.98-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Images/Video

Bug5235387_Screen_Recording_20210913-171127_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Sep 14, 2021
@MelvinBot
Copy link

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@francoisl
Copy link
Contributor

I feel like the simplest fix would be to cap the size of the amount you can enter to 10 digits? I think that's the max we allow in the backend anyway.
@akshayasalvi would you be able to submit a follow-up PR to limit the number of digits to 10 in this input please?

@francoisl
Copy link
Contributor

Oh haha I just realized the original PR was to cap the amount to 14 digits. I checked that our backend only allows for 10 digits, so 14 wouldn't have worked anyway.

@francoisl francoisl added the Reviewing Has a PR in review label Sep 14, 2021
@akshayasalvi
Copy link
Contributor

@francoisl Ohh this never came up in any previous discussions XD. Sure I'll add a cap of 10 digits.

@botify
Copy link

botify commented Sep 15, 2021

🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link
Author

I think we're good to close this one out CC @francoisl

@botify
Copy link

botify commented Sep 15, 2021

🚀 Deployed to staging by @francoisl in version: 1.0.98-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants