-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement custom Background Processing task from Scratch #52700
Comments
@gedu Eep! 4 days overdue now. Issues have feelings too... |
@gedu 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
@gedu 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
@gedu 12 days overdue. Walking. Toward. The. Light... |
@szymonrybczak did some progress and shared on slack: https://expensify.slack.com/archives/C05LX9D6E07/p1732714943702359?thread_ts=1731418897.322839&cid=C05LX9D6E07 |
Thanks for linking it here @gedu, so last week I managed to create PoC of running background task on iOS. This week I'm focusing of cleaning my implementation and making it more stable, so the things that are missing:
All changes that I'm making are available on my branch: https://github.com/callstack-internal/Expensify-App/commits/szymonrybczak/feat/setup-background-task-from-scratch/ |
@gedu Huh... This is 4 days overdue. Who can take care of this? |
Update from my side - the implementation is almost ready. One thing that we miss is EventEmitter, and currently the only way to setup EventEmitter with New Architecture in type-safe way is to use following method. It's available from React Native 0.76, so after talking with @mountiny I'll rebase with React Native upgrade branch to be able to use new recommend way of doing on my branch it and avoid creating workarounds as the upgrade PR is almost ready. |
Let me know when you make the PR and I could create a build for testing |
@gedu Still overdue 6 days?! Let's take care of this! |
iOS PR is ready to review and the iOS build is passing. I've started working on Android implementation now, hopefully I'll have some results to share next week 👍 |
@gedu Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
not overdue, working on Android |
@gedu Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@gedu Huh... This is 4 days overdue. Who can take care of this? |
@gedu Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
@gedu 10 days overdue. Is anyone even seeing these? Hello? |
@gedu 12 days overdue. Walking. Toward. The. Light... |
Not overdue: waiting for response for iOS: #53834 (comment) |
Android PR: #54616 |
@gedu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@gedu Huh... This is 4 days overdue. Who can take care of this? |
It's being tested but some crashing are happening: https://expensify.slack.com/archives/C05LX9D6E07/p1735639349792599?thread_ts=1727884875.529299&cid=C05LX9D6E07 |
@gedu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@gedu Eep! 4 days overdue now. Issues have feelings too... |
We just rebased two PRs on top of the |
@gedu Still overdue 6 days?! Let's take care of this! |
PR in review |
@gedu Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I think all PRs are merged, now a new fix will be up soon |
@gedu Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@mountiny can we close this issue? |
After a discussion on Slack, we have decided to implement background processing in-house instead of using an existing library. This decision was made to better tailor the solution to our needs and maintain greater control over the process.
The text was updated successfully, but these errors were encountered: