Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom Background Processing task from Scratch #52700

Closed
gedu opened this issue Nov 18, 2024 · 33 comments
Closed

Implement custom Background Processing task from Scratch #52700

gedu opened this issue Nov 18, 2024 · 33 comments
Assignees
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@gedu
Copy link
Contributor

gedu commented Nov 18, 2024

After a discussion on Slack, we have decided to implement background processing in-house instead of using an existing library. This decision was made to better tailor the solution to our needs and maintain greater control over the process.

Copy link

melvin-bot bot commented Nov 25, 2024

@gedu Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

@gedu 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Nov 29, 2024

@gedu 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Dec 3, 2024

@gedu 12 days overdue. Walking. Toward. The. Light...

@gedu
Copy link
Contributor Author

gedu commented Dec 3, 2024

@szymonrybczak did some progress and shared on slack: https://expensify.slack.com/archives/C05LX9D6E07/p1732714943702359?thread_ts=1731418897.322839&cid=C05LX9D6E07

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@szymonrybczak
Copy link
Contributor

Thanks for linking it here @gedu, so last week I managed to create PoC of running background task on iOS. This week I'm focusing of cleaning my implementation and making it more stable, so the things that are missing:

  • implement methods from AppDelegate so it’ll one-line change to just call a function from our module not as right now few lines,
  • add proper error handling and handle end of background task execution on native-side (when JS function finish executing)
  • add all necessary props to customize things.

All changes that I'm making are available on my branch: https://github.com/callstack-internal/Expensify-App/commits/szymonrybczak/feat/setup-background-task-from-scratch/

Copy link

melvin-bot bot commented Dec 9, 2024

@gedu Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@szymonrybczak
Copy link
Contributor

Update from my side - the implementation is almost ready. One thing that we miss is EventEmitter, and currently the only way to setup EventEmitter with New Architecture in type-safe way is to use following method. It's available from React Native 0.76, so after talking with @mountiny I'll rebase with React Native upgrade branch to be able to use new recommend way of doing on my branch it and avoid creating workarounds as the upgrade PR is almost ready.

@mountiny
Copy link
Contributor

Let me know when you make the PR and I could create a build for testing

@szymonrybczak
Copy link
Contributor

@mountiny #53834

Copy link

melvin-bot bot commented Dec 11, 2024

@gedu Still overdue 6 days?! Let's take care of this!

@szymonrybczak
Copy link
Contributor

iOS PR is ready to review and the iOS build is passing. I've started working on Android implementation now, hopefully I'll have some results to share next week 👍

Copy link

melvin-bot bot commented Dec 13, 2024

@gedu Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@gedu
Copy link
Contributor Author

gedu commented Dec 13, 2024

not overdue, working on Android

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 17, 2024

@gedu Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 17, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

@gedu Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 23, 2024

@gedu Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Dec 25, 2024

@gedu 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Dec 27, 2024

@gedu 12 days overdue. Walking. Toward. The. Light...

@gedu
Copy link
Contributor Author

gedu commented Dec 27, 2024

Not overdue: waiting for response for iOS: #53834 (comment)
On Android soon a separated PR will be created

@melvin-bot melvin-bot bot removed the Overdue label Dec 27, 2024
@gedu
Copy link
Contributor Author

gedu commented Dec 27, 2024

Android PR: #54616

Copy link

melvin-bot bot commented Dec 31, 2024

@gedu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 31, 2024
Copy link

melvin-bot bot commented Jan 2, 2025

@gedu Huh... This is 4 days overdue. Who can take care of this?

@gedu
Copy link
Contributor Author

gedu commented Jan 2, 2025

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

@gedu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

@gedu Eep! 4 days overdue now. Issues have feelings too...

@szymonrybczak
Copy link
Contributor

We just rebased two PRs on top of the main because Upgrade to 0.76 was merged yesterday, waiting for final C+ review now 👍

Copy link

melvin-bot bot commented Jan 10, 2025

@gedu Still overdue 6 days?! Let's take care of this!

@gedu
Copy link
Contributor Author

gedu commented Jan 13, 2025

PR in review

@melvin-bot melvin-bot bot removed the Overdue label Jan 13, 2025
Copy link

melvin-bot bot commented Jan 17, 2025

@gedu Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jan 17, 2025
@gedu
Copy link
Contributor Author

gedu commented Jan 20, 2025

I think all PRs are merged, now a new fix will be up soon

@melvin-bot melvin-bot bot removed the Overdue label Jan 20, 2025
Copy link

melvin-bot bot commented Jan 24, 2025

@gedu Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jan 24, 2025
@gedu
Copy link
Contributor Author

gedu commented Jan 28, 2025

@mountiny can we close this issue?

@melvin-bot melvin-bot bot removed the Overdue label Jan 28, 2025
@github-project-automation github-project-automation bot moved this from HIGH to Done in [#whatsnext] #quality Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
Status: Done
Development

No branches or pull requests

4 participants