-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[med] JAWS+Chrome: Chat: Chat status icons are not announced #5671
Comments
@Expensify/marketing Hi! We need copy for what a screen reader will read to the user if a chat is pinned, and if it has a draft message. My current drafts are: Draft: "Has draft message" Do these sound good to you? If not, let me know and I can swap them out. |
Triggered auto assignment to @ryanldonato ( |
@dangrous I just applied the "Waiting for copy" label. Whenever you need a copy review or suggestion, just add that label to any issue and a member of the marketing-content team will be assigned! |
Oh great, thank you! We should update the checklist to have that info - I guess what it says is old? |
Oh! Where's the checklist? |
It's the checklist that shows up when you make an App PR -
If you let me know what you think the correct steps are I can get that updated! I guess it's still the same process, just maybe |
Yeah I think just "adding the "Waiting for Copy" label for a copy review" or something like that would be great. It will auto-assign someone from the marketing team to review! I think it only works for issues, not PRs though. |
@dangrous just going to make one small tweak to the copy: Draft: Drafts If there are multiple drafted messages will they all appear in LHN like they do in slack? |
@ryanldonato Yep! Each chat with a draft will have this draft symbol on it (and therefore will be read out on the screen reader). As for the copy, my only question - since this is only read out by a screen reader - will that sound weird to just say "drafts"? I'm worried it'll sound like it's ONLY the drafts, or alternately a button to click on to view drafts, or something like that. For reference, with the copy I have now currently, it reads out "dgalerosen@expensifail.com Last Chat message preview Has draft message Chat pinned, group" so it would be, with this copy, "dgalerosen@expensifail.com last chat message preview drafts chat pinned, group". Happy to go with whatever you decide, just wanted to make sure you had all the info! (Also I definitely want to change that "last chat message preview" part because that's useless, but that will be on another issue.) |
@dangrous thanks for the context! I agree with you, let's go with: Drafts: |
Action Performed:
Prerequisites:
Expected Result:
The icons let users know which chats are pinned to the top and which have draft messages waiting to be addressed. This information should be announced when the chat room buttons are focused. e.g. 'Buttons [chat label] pinned to top or message in draft' or similar.
Actual Result:
Nothing is announced to indicate the meaning of the icons to users.
HTML:
<div class="css-1dbjc4n r-1awozwy" style="flex-direction: row; -webkit-box-orient: horizontal; -webkit-box-direction: normal;"><div class="css-1dbjc4n" style="margin-left: 8px;"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20" width="16" height="16" fill="#C6C9CA"><path d="M13.6 2.9L3 13.5l-1.4 4.1c-.1.5.2 1 .8.8L6.5 17 17.1 6.4l-3.5-3.5zm-9.8 14l-.5-.5.6-2 1.8 1.9-1.9.6zM18 5.6L14.4 2c1-1 2.5-1 3.5 0C19 3 19 4.6 18 5.6z"></path></svg></div></div>
Workaround:
No workaround
Area issue was found in:
Chat page
Failed WCAG checkpoints
1.1.1
User impact:
The screen reader users will not get the information that the status icons provide.
Suggested resolution:
Use the title attribute with the element to provide a proper name to the icons that describes its purposes. e.g. 'message in draft', 'Chat pinned', etc.
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/title
Platform:
Where is this issue occurring?
Version Number:
**Reproducible in staging?:**Yes
Reproducible in production?:
Notes/Photos/Videos: Any additional supporting documentation
Issue reported by:
Bug5187237_Screen_Readers-Chat-Chat_status_icons_are_not_announced.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: