Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in - "And" is missing in password requirements - Reported by: @parasharrajat #5871

Closed
isagoico opened this issue Oct 15, 2021 · 11 comments
Closed
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to log in and enter a new user email
  2. Click on the validation link
  3. In the password setup screen check the requirements

Expected Result:

Message says 1 capital letter, 1 lowercase letter and 1 number

Actual Result:

And is missing in the last requirement before 1 number and says 1 capital letter, 1 lowercase letter, 1 number

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.7-22

Reproducible in staging?: yes
Reproducible in production?: yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
image

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634061561200000

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@flodnv flodnv removed their assignment Oct 15, 2021
@flodnv flodnv added the Waiting for copy User facing verbiage needs polishing label Oct 15, 2021
@MelvinBot
Copy link

Triggered auto assignment to @gabrielessner (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@flodnv
Copy link
Contributor

flodnv commented Oct 15, 2021

@gabrielessner I just want to make sure we do want to make this copy update? And if yes, should we also make it on OldDot?

@gabrielessner
Copy link
Contributor

Yah its subtle but nice catch! I agree we should make this change and if its easy we should do it on OldDot too.

@flodnv
Copy link
Contributor

flodnv commented Oct 18, 2021

@gabrielessner don't we use the oxford comma, though?

@gabrielessner
Copy link
Contributor

You are right @flodnv I just searched slack because I remembered a recent conversation about oxford comma's and found this.

So it should read as:

1 capital letter, 1 lowercase letter, and 1 number

@MelvinBot MelvinBot removed the Overdue label Oct 18, 2021
@flodnv
Copy link
Contributor

flodnv commented Oct 18, 2021

Thanks! Actually I just realized this is already the copy on OldDot, so this is just matching it 😄

@flodnv flodnv assigned flodnv and unassigned gabrielessner Oct 18, 2021
@flodnv flodnv added Reviewing Has a PR in review and removed Waiting for copy User facing verbiage needs polishing labels Oct 18, 2021
@flodnv flodnv mentioned this issue Oct 18, 2021
5 tasks
@botify botify closed this as completed Oct 19, 2021
@parasharrajat
Copy link
Member

@mallenexpensify Am I eligible for reporting bonus here? Thanks.

@mallenexpensify
Copy link
Contributor

Yes @parasharrajat , thanks for reporting the issue. Please apply at https://www.upwork.com/jobs/~0193ab9496983c9195 and confirm here once you have

@parasharrajat
Copy link
Member

@mallenexpensify Done

@mallenexpensify
Copy link
Contributor

Paid Rajat in Upwork for reporting issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants