[HOLD for payment 2021-11-29] $500 Old Edited comments that are still open trigger the keyboard when the user is scrolling the conversation - Reported by: @parasharrajat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat.
2. Scroll back in the history.
3. Edit the message. Leave it as it is. Don't close the editor
4. Go back to LHN.
5. Open any other chat.
6. back to LHN.
7. Open back the previous chat.
8. Scroll back in the list slowly.
9. Screen will jump to the message being edited as soon as you reach closed to it.

Expected Result:

Old edited comment that are still open should not trigger the keyboard when the user is scrolling.

Actual Result:

Old Edited comments that are still open trigger the keyboard when the user is scrolling the conversation

Workaround:

Close or save the comments that are being edited.

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screencast.2021-10-09.21_25_07.mp4

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633794986065800

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Video

output_file.mp4

[SofiedeVreese]

Posted on Upwork: https://www.upwork.com/jobs/~018f79ec6f97efcf87

Adding Exported Label.

[MelvinBot]

Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NikkiWines]

Hmm this is kind of an interesting edge case... I think how we fix this depends on how we want to handle moving away from a chat with an active edit. Posted in #expensify-open-source here to get some thoughts on how to move forward.

[parasharrajat]

I think, Keyboard should only open when the user clicks to edit a message aka User action trigger.

[SofiedeVreese]

Hey @NikkiWines is this a dupe from #4756 that has been reopened? Feels like this case would fall under that other GH?

[NikkiWines]

mmm, I'd say they're related but not sure if they're exactly the same issue. In this one, it's more that navigating back to this chat and scrolling over an old open message will retrigger keyboard to pop up.

[parasharrajat]

They are completely different.
This => explained above.
#4756 => has to do with draft messages.

[SofiedeVreese]

Thanks for the explanation both, we'll keep this issue open then!

[SofiedeVreese]

Price increased to $500

[parasharrajat]

Proposal

AFAIK, I think there is only one way we can keep both autofocus and fix this issue. If we only autofocus, when the user edits messages (trigger edit action). Then old message being edited will not be focused when the user is scrolling. I think this is ideal behaviour as well.

If the user is scrolling back in the history, he should click on the edit box to focus it, instead of autofocus. But if a user press edits on any message, then it should be autofocused.

To do this:

1. Straight way to do this would be to capture the edit trigger in ReportActionItem via.

    componentDidUpdate(prevProps) {
        if (!prevProps.draftMessage && this.props.draftMessage) {
            // eslint-disable-next-line react/no-did-update-set-state
            this.setState({isMessgeEdited: true});
        }
    }

Then pass the Autofocus prop to ReportActionItemMessageEdit which will control the autofocus on underlined text input.

[NikkiWines]

I think that makes sense. cc: @SofiedeVreese would you hire @parasharrajat for this one?

[SofiedeVreese]

Yes sure can @NikkiWines.

@parasharrajat can you submit your Upwork proposal so I can hire you there? Thanks!

[parasharrajat]

@SofiedeVreese Job is private.

[SofiedeVreese]

@parasharrajat that should work better now! https://www.upwork.com/jobs/~018f79ec6f97efcf87

[SofiedeVreese]

I've just hired you in Upwork @parasharrajat !

[SofiedeVreese]

PR merged and QA ongoing.

[SofiedeVreese]

PR deployed, adding a payment hold 7 days from deploy.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.15-15 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove autofocus from the Edit messages and focus on the manual action #6138

If no regressions arise, payment will be issued on 2021-11-29. 🎊

[SofiedeVreese]

Job paid out & contract cancelled. Closing GH.

[parasharrajat]

@SofiedeVreese I think you missed the reporting bonus.

[SofiedeVreese]

Yes I did, sorry @parasharrajat ! I'll pay that one out now.

[SofiedeVreese]

Ok that bonus is now also paid out, sorry about that @parasharrajat !

[mallenexpensify]

It looks like I forgot to add the Company Offsite hold label to this issue. I've added the bonus for the hold to his Upwork payment.
The timeline was... Nov 8th I did a pass through all open issues in this repo and added the Company Offsite Hold label to most. I missed this one somehow and I should have added it.
The hold was lifted/removed on 11/15
The PR was deployed on 11/22

So... my thinking is .. this issue is eligble for the hold bonus. Sorry for missing it and any confusion.

[NikkiWines]

That makes sense to me, I was thinking it was ineligible for the n6-hold bonus but hadn't even considered the company offsite bonus (i.e. didn't consider this issue could've spanned multiple holds) and should've compared the dates as well. My bad and thanks for clearing things up @mallenexpensify