-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split bill - When writing a comment, Who paid gets hidden #6077
Comments
Triggered auto assignment to @zanyrenney ( |
Triggered auto assignment to @TomatoToaster ( |
Triggered auto assignment to @mallenexpensify ( |
thanks @mallenexpensify ! |
I might work on this if I can recreate this locally. I'm not sure yet if this needs to be internal, but please wait on the proposals until I try it out. |
@mvtglobally I'm a lil confused
If a user is requesting payment, then no payments would have been made at this point in the flow, right? |
Wanna bump this because I also want to understand the issue. Is it that when you add too many people, the Who paid gets cut off (in small mobile screens)? But you can still scroll up and down the list to see @mvtglobally Are you saying we should "fix position of" the |
@TomatoToaster When you look at the video in the issue, experience between mWeb and App is different. It makes sense to see "Who paid" on top, but not sure what should be the right experience. We are raising inconsistency between platforms. |
Aha! I didn't realize it would look different between Mobile app and mWeb, alright let me look into that. Thanks! |
Ah ok I see it's just that the keyboard is taking up the view vs. the keyboard overlaying on top of the view. hmm I don't think this is that big of an issue even though it is a slight inconsitency between mWeb and mobile. You can see everything again once you hide the keyboard. What do you think @mallenexpensify, should I close this? If this is worth fixing I'll apply the external label, I'm not sure how to solve this one. |
Issue reproducible during KI retests. |
Discussed with @mallenexpensify, I think we can close this. The discrepancy is a good find @mvtglobally, but this might be more tricky to make uniform than it's worth (it might just be part of how iOS shows keyboards in Safari vs Mobile Apps). Since you can see who paid after closing the keyboard again, it's still functional. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
4 It will show attendee select screen, So select two or more attendees and click next
Expected Result:
When writing a comment, we should see the function who paid
Actual Result:
When writing a comment, ''Who paid'' is hiding
Workaround:
n/a
Platform:
Where is this issue occurring?
**Version Number:1.1.10-0
**Reproducible in staging?:Y
**Reproducible in production?:Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Video
Expensify/Expensify Issue URL:
**Issue reported by:Applause
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: