Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split bill - When writing a comment, Who paid gets hidden #6077

Closed
mvtglobally opened this issue Oct 27, 2021 · 13 comments
Closed

Split bill - When writing a comment, Who paid gets hidden #6077

mvtglobally opened this issue Oct 27, 2021 · 13 comments
Assignees

Comments

@mvtglobally
Copy link

mvtglobally commented Oct 27, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Click FAB + > Split bill
  3. Enter amount and click next
    4 It will show attendee select screen, So select two or more attendees and click next
  4. You will land at confirmation page.
  5. Write a comment

Expected Result:

When writing a comment, we should see the function who paid

Actual Result:

When writing a comment, ''Who paid'' is hiding

Workaround:

n/a

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

**Version Number:1.1.10-0
**Reproducible in staging?:Y
**Reproducible in production?:Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Video

Expensify/Expensify Issue URL:
**Issue reported by:Applause
Slack conversation:

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering Daily KSv2 labels Oct 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot
Copy link

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 27, 2021
@zanyrenney
Copy link
Contributor

zanyrenney commented Oct 27, 2021

I can't test this properly as i can't upgrade wallet due to no SSN > needing to do ondifo with US credentials:
2021-10-27_11-24-56

reassigning autoassigner to get someone US.

@zanyrenney zanyrenney removed their assignment Oct 27, 2021
@zanyrenney zanyrenney added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 27, 2021
@zanyrenney
Copy link
Contributor

thanks @mallenexpensify !

@TomatoToaster
Copy link
Contributor

I might work on this if I can recreate this locally. I'm not sure yet if this needs to be internal, but please wait on the proposals until I try it out.

@mallenexpensify
Copy link
Contributor

@mvtglobally I'm a lil confused

When writing a comment, we should see the function who paid

If a user is requesting payment, then no payments would have been made at this point in the flow, right?
This is what I'm seeing when attempting to reproduce. Can you provide more details/examples and any screenshots that might be helpful?
image

@TomatoToaster
Copy link
Contributor

TomatoToaster commented Oct 28, 2021

Wanna bump this because I also want to understand the issue. Is it that when you add too many people, the Who paid gets cut off (in small mobile screens)?
That does happen here:
image

But you can still scroll up and down the list to see Who Paid and the Who Was There
image

@mvtglobally Are you saying we should "fix position of" the Who Paid part and scroll only the Who Was There in this case? I think that's not a super big deal what do you think @mallenexpensify

@mvtglobally
Copy link
Author

@TomatoToaster When you look at the video in the issue, experience between mWeb and App is different.
In one case, when you write a comment the page and "Who paid" gets shifted to the top and not visible.
In another case, "Who was there" section gets hidden behind the keyboard and "Who Paid" clearly visible on top.

It makes sense to see "Who paid" on top, but not sure what should be the right experience.

We are raising inconsistency between platforms.

@TomatoToaster
Copy link
Contributor

Aha! I didn't realize it would look different between Mobile app and mWeb, alright let me look into that. Thanks!

@TomatoToaster
Copy link
Contributor

TomatoToaster commented Nov 1, 2021

Ah ok I see it's just that the keyboard is taking up the view vs. the keyboard overlaying on top of the view. hmm I don't think this is that big of an issue even though it is a slight inconsitency between mWeb and mobile. You can see everything again once you hide the keyboard. What do you think @mallenexpensify, should I close this?

If this is worth fixing I'll apply the external label, I'm not sure how to solve this one.

@mvtglobally
Copy link
Author

Issue reproducible during KI retests.

@TomatoToaster
Copy link
Contributor

Discussed with @mallenexpensify, I think we can close this. The discrepancy is a good find @mvtglobally, but this might be more tricky to make uniform than it's worth (it might just be part of how iOS shows keyboards in Safari vs Mobile Apps).

Since you can see who paid after closing the keyboard again, it's still functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants