Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$8000] Feature Request - Profile / Workspace - Allow avatar editing via cropping, rotation and zooming - Reported by: @parasharrajat #6301

Closed
isagoico opened this issue Nov 15, 2021 · 164 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@isagoico
Copy link

isagoico commented Nov 15, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to profile settings
  2. Upload a new profile picture

Expected Result:

User should be able to edit the picture before setting the new avatar (Like zooming and cropping)

Actual Result:

User is not given the option to edit the profile picture when uploading a new avatar.

Workaround:

User has to edit the picture before uplaoding.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.14-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1636994572206400

View all open jobs on GitHub

Solution

This is the final UI agreed upon:
image

The two new icons you will need (zoom, rotate) are here: Icons.zip

@isagoico isagoico added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Nov 15, 2021
@MelvinBot
Copy link

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Nov 15, 2021
@MelvinBot
Copy link

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mallenexpensify
Copy link
Contributor

Added Engineering label , assigned Deeter, to check to ensure this can be worked on by a contributor

@deetergp
Copy link
Contributor

I can't think of any reason this couldn't be done by a contributor.

@deetergp deetergp added the External Added to denote the issue can be worked on by a contributor label Nov 16, 2021
@deetergp deetergp removed their assignment Nov 16, 2021
@botify botify removed the Daily KSv2 label Nov 16, 2021
@MelvinBot MelvinBot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 16, 2021
@MelvinBot
Copy link

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mallenexpensify
Copy link
Contributor

https://www.upwork.com/jobs/~01c68ed933432e239b
Job posted 😎

@parasharrajat
Copy link
Member

Looks like this needs Design @Expensify/design

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Nov 18, 2021

I think you're right @parasharrajat. Let me assign someone for 👀 and review to see what their initial thoughts, pointers, feedback are. @shawnborton (who was auto-assigned) can you take a look?

@MelvinBot
Copy link

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

@tgolen
Copy link
Contributor

tgolen commented Nov 19, 2021

I would like to push the pause button on this for a bit. I think it's an interesting feature request, but I think we should spend a little more time determining if it's a feature that we WANT right now or not. I would like to see whoever proposed it (I think @parasharrajat) craft a problem solution statement for this. I am not sure what problem it solves, so therefore, I am not yet on board with this "solution".

@tgolen
Copy link
Contributor

tgolen commented Nov 19, 2021

(let me know if you're familiar with how we do problem/solution statements or not)

@parasharrajat
Copy link
Member

I definitely don't know your problem solution technique 😀 but I can try to create a problem statement.

@tgolen
Copy link
Contributor

tgolen commented Nov 19, 2021

Haha, sure! So this is the template that we use for our internal issue repo:

# Problem

# Why is this important?

# Solution

Some suggestions to help you out:

  • Good problems don't ever mention the solution
  • Framing things from the customer perspective is most helpful
  • A good forumla to follow for the problem is "When X happens, it leads to Y, which is important to solve because of Z"

@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2022
@tgolen
Copy link
Contributor

tgolen commented Aug 12, 2022

not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 12, 2022
@vitalii-tb
Copy link
Contributor

Not overdue

@tgolen
Copy link
Contributor

tgolen commented Aug 22, 2022

Still not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 22, 2022
@tgolen tgolen added Monthly KSv2 and removed Daily KSv2 labels Aug 25, 2022
@melvin-bot melvin-bot bot removed the Overdue label Aug 25, 2022
@tgolen
Copy link
Contributor

tgolen commented Aug 25, 2022

I'm going to change the label so this doesn't keep going overdue.

@mallenexpensify
Copy link
Contributor

I unassigned Ariel and assigned myself (I was OOO for a while)

What are we waiting for to close this issue and to pay the contributors? This is the associated PR, correct? Looks like it merged a while ago

@parasharrajat
Copy link
Member

Yeah, waiting for the deployment cycle to complete.

@parasharrajat
Copy link
Member

This should be ready for payment now.

@mallenexpensify
Copy link
Contributor

@tgolen , can you chime in about releasing payment plz. Looks like the PR hit staging but never production, so I'm a bit confused. Also, the title never auto-updated.
#8511 (comment)

@tgolen
Copy link
Contributor

tgolen commented Sep 6, 2022

I know the comments were broken for one deploy cycle, maybe that's what got messed up here. I just checked production and the feature is definitely there, so I think we are fine to move forward with payment.

@parasharrajat
Copy link
Member

PR was deployed to PROD 14 days back #10253 (comment)

@mallenexpensify
Copy link
Contributor

Thanks @tgolen

Paid @tabakharniuk $8,000! Thanks!
@parasharrajat , your hire/job got cancelled somehow. Can you please accept the new job I created?
https://www.upwork.com/jobs/~0187ef9e300849eeba

Please post here once you have (and... remind me to add $250 for reporting :) )

@vitalii-tb
Copy link
Contributor

Thank you @parasharrajat @mallenexpensify @tgolen!

@mallenexpensify
Copy link
Contributor

Paid @parasharrajat $8250 for C+ and reporting. Thanks again for the help, happy to see this big feature request wrapped up.

Curious of any learnings from this one that might help with other feature requests (since... bugs are much more straight forward). I think there needs to be a significant initial investment in the design and concrete deliverable in order to alleviate excessive back n' forth. Espec with contributors and C+ who won't have as much context and understanding of how the feature will work on/with our product and roadmap. Anywho... gonna close this now :)

@mallenexpensify
Copy link
Contributor

@tabakharniuk , I just used the feature and it worked like a charm! Thanks again for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests