-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$8000] Feature Request - Profile / Workspace - Allow avatar editing via cropping, rotation and zooming - Reported by: @parasharrajat #6301
Comments
Triggered auto assignment to @mallenexpensify ( |
Triggered auto assignment to @deetergp ( |
Added |
I can't think of any reason this couldn't be done by a contributor. |
Triggered auto assignment to @tgolen ( |
https://www.upwork.com/jobs/~01c68ed933432e239b |
Looks like this needs Design @Expensify/design |
I think you're right @parasharrajat. Let me assign someone for 👀 and review to see what their initial thoughts, pointers, feedback are. @shawnborton (who was auto-assigned) can you take a look? |
Triggered auto assignment to @shawnborton ( |
I would like to push the pause button on this for a bit. I think it's an interesting feature request, but I think we should spend a little more time determining if it's a feature that we WANT right now or not. I would like to see whoever proposed it (I think @parasharrajat) craft a problem solution statement for this. I am not sure what problem it solves, so therefore, I am not yet on board with this "solution". |
(let me know if you're familiar with how we do problem/solution statements or not) |
I definitely don't know your problem solution technique 😀 but I can try to create a problem statement. |
Haha, sure! So this is the template that we use for our internal issue repo:
Some suggestions to help you out:
|
not overdue |
Not overdue |
Still not overdue |
I'm going to change the label so this doesn't keep going overdue. |
I unassigned Ariel and assigned myself (I was OOO for a while) What are we waiting for to close this issue and to pay the contributors? This is the associated PR, correct? Looks like it merged a while ago |
Yeah, waiting for the deployment cycle to complete. |
This should be ready for payment now. |
@tgolen , can you chime in about releasing payment plz. Looks like the PR hit staging but never production, so I'm a bit confused. Also, the title never auto-updated. |
I know the comments were broken for one deploy cycle, maybe that's what got messed up here. I just checked production and the feature is definitely there, so I think we are fine to move forward with payment. |
PR was deployed to PROD 14 days back #10253 (comment) |
Thanks @tgolen Paid @tabakharniuk $8,000! Thanks! Please post here once you have (and... remind me to add $250 for reporting :) ) |
Thank you @parasharrajat @mallenexpensify @tgolen! |
Paid @parasharrajat $8250 for C+ and reporting. Thanks again for the help, happy to see this big feature request wrapped up. Curious of any learnings from this one that might help with other feature requests (since... bugs are much more straight forward). I think there needs to be a significant initial investment in the design and concrete deliverable in order to alleviate excessive back n' forth. Espec with contributors and C+ who won't have as much context and understanding of how the feature will work on/with our product and roadmap. Anywho... gonna close this now :) |
@tabakharniuk , I just used the feature and it worked like a charm! Thanks again for the help |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
User should be able to edit the picture before setting the new avatar (Like zooming and cropping)
Actual Result:
User is not given the option to edit the profile picture when uploading a new avatar.
Workaround:
User has to edit the picture before uplaoding.
Platform:
Where is this issue occurring?
Version Number: 1.1.14-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1636994572206400
View all open jobs on GitHub
Solution
This is the final UI agreed upon:
The two new icons you will need (zoom, rotate) are here: Icons.zip
The text was updated successfully, but these errors were encountered: