Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN #6426

Closed
kavimuru opened this issue Nov 23, 2021 · 8 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app and login.
  2. Click on New Chat
  3. Search for a user that you don't have any messages with and open the chat.

Expected Result:

When you navigate from the chat that doesn't have a message, it disappears from the left hand navigation.

Actual Result:

When you navigate from the chat that doesn't have a message, it appears at the LHN with "comment deleted" for that user

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.16-1

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Bug5341986_23 11-new_message-1

Bug5341986_23.11-new_message-2.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Nov 23, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam
Copy link
Contributor

thienlnam commented Nov 23, 2021

Looks like this is from #4133

cc @chiragsalian

@chiragsalian
Copy link
Contributor

Oh i missed this, assigning to self as i investigate.

@chiragsalian chiragsalian self-assigned this Nov 24, 2021
@parasharrajat
Copy link
Member

@chiragsalian I think it was discussed here #3293 (comment) and fixed here #6458

@chiragsalian
Copy link
Contributor

oh nice, thanks for that @parasharrajat 🙇
Looks like that PR resolves this issue. I'll link it here and ensure it get's CP-d.

@chiragsalian
Copy link
Contributor

@kavimuru the fix has been CP-d. Can you retest and close issue when you get the chance.

@chiragsalian chiragsalian added the Reviewing Has a PR in review label Nov 24, 2021
@isagoico
Copy link

Retest for this was a pass! closing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants