Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - VBA - User not directed with the secondary login model open tapping "Add work" email #6475

Closed
kbecciv opened this issue Nov 25, 2021 · 6 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Nov 25, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app and login with gmail account
  2. Initiate VBA flow and add an "Open" bank account.
  3. At the last step tap "Add work email address"

Expected Result:

Opens new browser tab on OldDot and directs user to Settings > Account Details > Add secondary login with the secondary login modal open

Actual Result:

User is taken OldDot app with login screen

Workaround:

Uknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Desktop App

Version Number: 1.1.16-6

Reproducible in staging?: Yes
Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5343624_Image_from_iOS.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Nov 25, 2021
@MelvinBot
Copy link

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Nov 25, 2021
@kbecciv kbecciv changed the title User not directed with the secondary login model open iOS - VBA - User not directed with the secondary login model open Nov 25, 2021
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 25, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title iOS - VBA - User not directed with the secondary login model open iOS - VBA - User not directed with the secondary login model open tapping Add work email Nov 25, 2021
@kbecciv kbecciv changed the title iOS - VBA - User not directed with the secondary login model open tapping Add work email iOS - VBA - User not directed with the secondary login model open tapping "Add work" email Nov 25, 2021
@luacmartins
Copy link
Contributor

I can take this since I worked on this code.

@luacmartins
Copy link
Contributor

It seems that iOS handles URL encoding differently. Working on a fix now.

@luacmartins
Copy link
Contributor

Fix up #6479

@luacmartins luacmartins added the Reviewing Has a PR in review label Nov 25, 2021
@botify botify closed this as completed Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants