-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-02-22] Android - Close account text box pointer doesn't start on top - Reported by @Tushu17 #7380
Comments
Triggered auto assignment to @JmillsExpensify ( |
PROPOSAL (if considered external)we need to add: App/src/pages/settings/Security/CloseAccountPage.js Lines 73 to 80 in 921fa4f
Screenshot |
Upwork job is posted here: https://www.upwork.com/jobs/~019e4050a252db42da |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Triggered auto assignment to @iwiznia ( |
thanks, proposal posted on upwork @JmillsExpensify |
@mateusbra Your proposal looks good to me. Can't we pass the same via styles? cc: @iwiznia 🎀 👀 🎀 C+ reviewed |
@parasharrajat sure we can! |
Alright, lets do that instead. |
@parasharrajat I tried passing it by style props and I think we are unable to do it. I think we would have to make changes within BaseTextInput.js to spread thoses passed styles here: App/src/components/TextInput/BaseTextInput.js Lines 176 to 201 in 0758296
or if we don't want to do that we could just use App/src/pages/workspace/WorkspaceInvitePage.js Lines 292 to 303 in 0758296
|
|
App/src/components/TextInput/index.native.js Lines 6 to 17 in 0758296
So, we should follow with my first proposed fix (passing it direcly)? |
@parasharrajat do you think I could raise a new issue fixing this on slack?
as in the future we are going to want it to work as expected. |
Already fixed it here #7318. We can wait for that to merge. |
Ok, so, once I be hired on upwork I'll rise a PR |
@JmillsExpensify did you received my proposal in upwork? |
Yes! Thanks, I received and hired you for your proposal in Upwork. Please continue with the PR. |
Thank you @JmillsExpensify ! |
PR ready for review! |
Thanks for the quick turnaround! |
PR deployed to staging yesterday. We're moving forward MelvinBot. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.38-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-02-22. 🎊 |
Woo! Now it's just a question of time. I'll circle back for payment following the regression period. |
Jumping in to processes contributor payments. I'll close the issue when that step is complete for all contributors. |
📣 @mateusbra You have been assigned to this job by @JmillsExpensify! |
All contributors, let me know if you have any issues with payments. Thank you! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Text pointer should start on top
Actual Result:
Close account text box pointer doesn't start on top
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.32-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
f0c2b18c-f8a7-4c65-abc4-3aa6e5c53780.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642236846478400
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: