[HOLD for payment 2022-03-24] mWeb- Unable to move to another line by clicking "return" button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. Log with any account
3. Navigate to Settings > Workspace > Manage members > Invite
4. Start typing in the custom message field
5. Hit "return" button

Expected Result:

Able to move to another line

Actual Result:

Unable to move to another line by click "Return" button and error message is showing below. If you navigate back to the Manage members page - shows invited member as many as you tap on "return" button before. Also unable to remove the user from the Manage members.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.1.38.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.11.MP4

Image.from.iOS.10.MP4

mWeb.7612-1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Gonals]

Setting tags and sending to the pool!

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Job created https://www.upwork.com/jobs/~016203ba9d6e3f0330

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[ahmdshrif]

@parasharrajat but I think we need to pressOnEnter to work on some cases when text input is activated.
for the example login form.

[parasharrajat]

Yeah, I pointed out.

we need to allow the form submitting on inputs as well. On the other hand, I think we should allow the events to pass down to TextArea or multiline inputs instead of intercepting them for submission.

That's why

We would not use captureOnInputs but we will bypass pressOnEnter when input is multiline(textarea).

cc: @luacmartins What do you think?

[MelvinBot]

@JmillsExpensify, @ahmdshrif, @luacmartins, @mallenexpensify, @parasharrajat Eep! 4 days overdue now. Issues have feelings too...

[luacmartins]

@parasharrajat Sorry for the late response. I was ooo for most of last week! I like your suggestion and think we should move forward with it. Thanks for the suggestion!

[parasharrajat]

Ok. @ahmdshrif Lets do that. Thanks for your patience.
🎀 👀 🎀 C+ reviewed

[luacmartins]

I'll move this to Weekly while @ahmdshrif works on it.

[mallenexpensify]

Progressing, commenting so the issue won't go overdue

[parasharrajat]

PR is on HOLD for #7702

[mallenexpensify]

@parasharrajat , if the PR is on hold then I should put this issue on hold too... right?

[ahmdshrif]

it merged and deploy to stage today #7920 (comment)
I also apply for the job but it get closed

[parasharrajat]

Sorry, I forgot to comment on the issue as well. @ahmdshrif is correct PR is merged now. This is no more on hold.

[mallenexpensify]

New Upwork job created https://www.upwork.com/jobs/~01ed28e9d59cefbbd0

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: mWeb- Unable to move to another line by clicking "return" button  #7920

If no regressions arise, payment will be issued on 2022-03-24. 🎊

[mallenexpensify]

Hired @ahmdshrif , please accept the offer https://www.upwork.com/jobs/~01ed28e9d59cefbbd0
@parasharrajat I think I just 'hired' you too. I was testing a different flow where, instead of 'inviting' you to the job (which would require you to then apply > me hire > you approve) I clicked a 'hire' button to hopefully save a step, will you let me know if anything looks different on your end?

[parasharrajat]

All looks good @mallenexpensify. I directly got the offer.

[mallenexpensify]

@parasharrajat and @ahmdshrif both paid $250