Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Offline message - The offline message is disappearing when Wifi is turned back #7772

Closed
kavimuru opened this issue Feb 16, 2022 · 5 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre-Condition: Have another account you have access to and two different devices

  1. Access https://staging.new.expensify.com/[](javascript:)
    and Log into a valid Account A on Device A
  2. Click on the chat with the other Account B
  3. Disable internet connection by turning off Wifi on Device A
  4. Send some messages, while offline, to Account B you have access to
  5. Enable internet connection by turning on Wifi on Device A
  6. Log into Account B on device B and verify the messages from Account A

Expected Result:

  1. While sending messages Offline the user should see a message under the text box stating that he/she is in fact offline while writing

  2. Once logged into Account B on Device B the user should have received the message from Account A

Actual Result:

  1. While the user is typing in Offline mode on Device A, he/she does NOT see any message whatsoever stating that they are offline (This also happens on prod build https://new.expensify.com/[](javascript:)
    )

  2. Once logged into Account B on Device B the user has not received any message from Account A (Note: If the tab is refreshed on Account A on Device A, after reenabling Wifi, the entire text message that had been sent while wifi was disabled disappears as if it were never written)

Note : If the user send a message after the wifi is turned ON, only the message sent after the Wifi is ON will be received
The Account A used had 2FA enabled and this bug is reproduced for individual DM's or Group Messages. Also it is NOT reproduced vice versa, from iPhone to Mac, only from Mac to iPhone

Workaround:

Unknwon

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.39_1
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5455342_Console.txt

Bug5455342_Prod_video.mp4
Bug5455342_Message_no_Received_with_Wifi_OFF.mp4
Bug5455342_Video_showing_both_devices_and_message_sent_after_Wifi_turned_ON.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Feb 16, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru changed the title [Chat] Web - Upload Offline message - The offline message is disappearing when Wifi is turned back Web - Offline message - The offline message is disappearing when Wifi is turned back Feb 16, 2022
@kidroca
Copy link
Contributor

kidroca commented Feb 16, 2022

Seems like the user being offline is not getting detected and is related to:

Report comments are only going to be persisted if we know we're offline
Since they are not, they are getting lost (like any other non persisted request) when we refresh

Solving the ticket above and making sure internet connectivity is detected correctly would solve the current issue

@kidroca
Copy link
Contributor

kidroca commented Feb 16, 2022

I don't think this is deploy blocker

  • code around Network connectivity detection hasn't been changed recently
  • network related packages (net-info) haven't been changed recently

Also it's stated that the bug is already on PROD: "This also happens on prod build"

@marcochavezf
Copy link
Contributor

Thanks for that @kidroca! Yeah, this is not blocker, I'm going to close the ticket because the issue is already being addressed in the issue that @kidroca linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants