Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - Missing Emoji icon in the input box for the touch screen laptop. #8100

Closed
kbecciv opened this issue Mar 11, 2022 · 7 comments
Closed
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Mar 11, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with andreylazutkinutest+qqq2gmail.com
  3. Open any chat

Expected Result:

Emoji icon is displayed and able to use it.

Actual Result:

Missing Emoji icon in the input box for the touch screen laptop.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web (Windows 10/touch screen laptop)

Version Number: 1.1.42.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): andreylazutkinutest+qqq@gmail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.246.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thesahindia
Copy link
Member

I think my PR is responsible for this.

@mountiny mountiny assigned mountiny and thesahindia and unassigned nkuoch Mar 11, 2022
@mountiny
Copy link
Contributor

This is a regression from a PR where I was CME so I have assigned it to myself and a contributor who worked on it. cc @rushatgabhane

Let's discuss in the PR how to fix it https://github.com/Expensify/App/pull/7851/files#r825096050

I guess there is no perfect solution here and we just need to take some breakpoints ideally not making new ones and accept it will not be great UI everywhere, but the number of viewports/devices where the problem will occur will be far less.

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Mar 11, 2022
@mountiny
Copy link
Contributor

As this is regression, I have unassigned you, sorry for confusion 😄

@mountiny
Copy link
Contributor

Closing this in favour of reopening the OG issue #7585

@kbecciv
Copy link
Author

kbecciv commented Mar 13, 2022

@mountiny Also Ipad7 has the same issue as well.
Ipad 1203

@mountiny
Copy link
Contributor

mountiny commented Mar 13, 2022

@kbecciv On ipad landscape it is expected behaviour. There is a native emoji keyboard which users would most likely use.

The larger screen windows tablets are bigger problem which are trying to resolve in the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants