[HOLD for payment 2022-05-20][$2000] IOU balance disappears after sending money to owed user - reported by @Santhosh-Sellavel

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create two accounts User A and User B
2. Login with those accounts on different devices into the newDot app.
3. Now Request money from User B as User A Ex: Amount 2000
4. Now using from User B send money i.e 1000 back to User A

Expected Result:

IOU Balance should be shown until fully settled.

Actual Result:

IOU Balance gets hidden from LHN for both users. One more Issue, IOU card in the chat list also gets hidden.

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.46-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-03-25.at.12.10.38.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1646161753960719

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

Opening up for external. The requisites for rendering
somewhere from here below is breaking would be my guess, but would need extra eyes to see why this case isn't being handled:

App/src/pages/home/report/ReportActionItem.js

Lines 132 to 136 in 21ab943

	<IOUAction
	chatReportID={this.props.reportID}
	action={this.props.action}
	isMostRecentIOUReportAction={this.props.isMostRecentIOUReportAction}
	/>

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jliexpensify]

Posted

Internal - https://www.upwork.com/ab/applicants/1511226520114122752/job-details
External - https://www.upwork.com/jobs/~01782081efffe44962

Invited @Santhosh-Sellavel

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jliexpensify]

Price doubled and promoted!

[Julesssss]

Making this internal and I'll submit a fix. I've located the bug and it required some existing IOU knowledge.

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Internal assigner, not assigning anyone new.

[Julesssss]

@jliexpensify would you mind closing the UpWork issue and paying @Santhosh-Sellavel for raising the bug please?

[Julesssss]

The issue is that 'Send Money' changed how IOUReports work, causing this regression. A new iouReport is created then immediately closed which is a big problem, as we expect (and require) iouReports handled within this function to be open:

therefore should only be called if we are certain that the fetched iouReport is currently open - else we would overwrite the existing open iouReportID with a closed iouReportID.

I think we should return early if the iouAction is from 'send money'.

[Julesssss]

Conveniently, the IOU action type is available in the reportAction:

if (reportAction.originalMessage.type == 'pay') {
    return;
}

[mallenexpensify]

Paid @Santhosh-Sellavel $250 for reporting and closed the Upwork job

[Julesssss]

PR in progress