Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-05-20][$500] Auto-filling my information on Request a call page fills my name in the opened chat's compose box too - reported by @adeel0202 #8456

Closed
mvtglobally opened this issue Apr 4, 2022 · 28 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://new.expensify.com/ on Safari web
  2. Go to any workspace
  3. Click on Get assistance icon
  4. Click on Request a setup call
  5. Click on First name field
  6. Click on the auto-fill icon to autofill your info
  7. Observe that your auto-filled name is filled on the opened chat's compose box too

Expected Result:

Opened chat should not be filled with auto-filled name

Actual Result:

Opened chat is also filled with auto-filled name

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web (Safari)

Version Number: 1.1.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

autofill.issue.mov

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1647887778628489

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Apr 4, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2022

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 4, 2022
@sophiepintoraetz sophiepintoraetz added Engineering Weekly KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 labels Apr 4, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2022

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sophiepintoraetz sophiepintoraetz removed their assignment Apr 4, 2022
@luacmartins
Copy link
Contributor

This should be external!

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Apr 4, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2022

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 4, 2022
@MitchExpensify
Copy link
Contributor

Upwork Job

@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 4, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 4, 2022

Current assignee @luacmartins is eligible for the Exported assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title Auto-filling my information on Request a call page fills my name in the opened chat's compose box too - reported by @adeel0202 [$250] Auto-filling my information on Request a call page fills my name in the opened chat's compose box too - reported by @adeel0202 Apr 4, 2022
@melvin-bot melvin-bot bot added the Overdue label Apr 13, 2022
@luacmartins
Copy link
Contributor

Still looking for proposals.

@melvin-bot melvin-bot bot removed the Overdue label Apr 13, 2022
@parasharrajat
Copy link
Member

Ok. Thanks. I will push the PR shortly.

@parasharrajat
Copy link
Member

On it today.

@parasharrajat
Copy link
Member

Should we remove the Help Wanted label here?

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 28, 2022
@luacmartins
Copy link
Contributor

Ah yes! Removed :)

@mallenexpensify mallenexpensify changed the title [$500] Auto-filling my information on Request a call page fills my name in the opened chat's compose box too - reported by @adeel0202 [HOLD for payment 2022-05-20][$500] Auto-filling my information on Request a call page fills my name in the opened chat's compose box too - reported by @adeel0202 May 20, 2022
@mallenexpensify mallenexpensify added the Awaiting Payment Auto-added when associated PR is deployed to production label May 20, 2022
@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 23, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 23, 2022

This issue has not been updated in over 15 days. @luacmartins, @parasharrajat, @MitchExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label May 23, 2022
@luacmartins
Copy link
Contributor

I believe the only action item left here is payment. @MitchExpensify could you pay @parasharrajat for the fix and close this issue please?

@parasharrajat
Copy link
Member

@luacmartins MitchExpensify is OOO so we need someone else here.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 Daily KSv2 labels May 26, 2022
@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels May 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2022

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@luacmartins
Copy link
Contributor

@laurenreidexpensify I just reassigned this since Mitch is ooo until Jun 9. The only action item left here is to pay @parasharrajat for the fix. Could you do that please?

@laurenreidexpensify
Copy link
Contributor

@parasharrajat offer sent

@adeel0202
Copy link
Contributor

I'm also eligible for the reporting bonus :)

@laurenreidexpensify
Copy link
Contributor

cool @adeel0202 offer sent to you too! sorry we missed you there!

@adeel0202
Copy link
Contributor

No worries, @laurenreidexpensify. I have accepted the offer. Thanks.

@laurenreidexpensify
Copy link
Contributor

everyone has been paid, thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

10 participants