[HOLD for payment 2022-04-27] [$250] Room Settings - The word "Restricted" is not translated into Spanish.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. Log any expensifail account
3. Open any room in Spanish
4. Click Settings

Expected Result:

The word "restricted" must be translated into Spanish - Restringida

Actual Result:

The word "restricted" is not translated into Spanish.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.52.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): n/a

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Upwork URL: https://www.upwork.com/jobs/~01905625ed837532d1

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Puneet-here]

Proposal

To fix we need to change the code here:

App/src/pages/ReportSettingsPage.js

Line 237 in d060fc2

<Text numberOfLines={1} style={[styles.reportSettingsVisibilityText]}>{this.props.report.visibility}</Text>

like this:

<Text numberOfLines={1} style={[styles.reportSettingsVisibilityText]}>
     {this.props.translate(`newRoomPage.visibilityOptions.${this.props.report.visibility}`)}
</Text>

Here I am accessing the value given in en/es.js

[nkuoch]

We'll need to make sure any possible value of visibility exists in the translations

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

Job on upwork here: https://www.upwork.com/jobs/~01905625ed837532d1

I'm OoO next week, so feel free to pull the external trigger again if anything is needed from the CM team in the meantime. 👍

[parasharrajat]

@Puneet-here 's proposal looks good.

cc: @thienlnam

🎀 👀 🎀 C+ reviewed

[thienlnam]

Yup looks good to me as well, hiring @Puneet-here

[melvin-bot]

📣 @Puneet-here You have been assigned to this job by @thienlnam!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Puneet-here]

Hi, I have made the PR.
Thanks.

[thienlnam]

Issue has been merged, deployed on staging 5 days ago

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[trjExpensify]

Back from OOO, @Puneet-here I've sent you the offer on Upwork to get the contract in place. You too, @parasharrajat for C+.

[Puneet-here]

Thanks, I have accepted the offer.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.55-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix room visibility translation #8583

If no regressions arise, payment will be issued on 2022-04-27. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[trjExpensify]

Settled up with you both in Upwork, thanks!