IOS - Profile - Time zone is automatically selected without clicking on it.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Click Profile
4. Unselect Set my timezone automatically
5. Open the Time zone box and start search for your zone
6. Stop on one of it

Expected Result:

Time zone must be selected when click on it

Actual Result:

Time zone is automatically selected without clicking on it.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.55.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5538573_ios_time_zone_19.04.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pecanoro]

@kbecciv You mean that the time zone is stored by just scrolling down or up in the options?

[kbecciv]

@pecanoro The time zone is selected automatically when you just stop scrolling. In production app - in order to get it selected you need to tap on it.

[luacmartins]

This issue was first reported here. Was it not solved in this PR?

[kbecciv]

@luacmartins This is slightly different issue #8570 than we just reported.

[luacmartins]

Ah I see, this is for manual timezone selection. Yea, seems like a different issue then.

[pecanoro]

Maybe the same PR caused it? #7807 I will try to debug it

[pecanoro]

Hmm, I actually think it might have been @chiragsalian's PR since the rest of the selectors are working fine. I am going to test it without that PR.

[pecanoro]

Yes, it was Chirag's PR, when he added the value, it stopped working. @chiragsalian Why do we need to add the key there? I can't find where it is used as a prop.

[luacmartins]

The key was added as a temporary fix for this deploy blocker

[pecanoro]

That temporary fix for that deploy blocker created this one 😄 Why do we need that key parameter and why can't we use something else? Not sure where it is used

[chiragsalian]

Yup like carlosM mentioned. It was a temporary fix that was suggested by the author here - #7807 (comment) until a more permanent fix could be found. Definitely annoying it created another deploy blocker. Shall post in the PR and investigate too.

[pecanoro]

I can help you with it, it's just that I am not completely sure how adding the key to the picker broke it since I can't seem to find where that key is being used

[pecanoro]

Maybe the problem is not passing the key down to the BasePicker along with the value?

[chiragsalian]

@kbecciv, the fix for this has been cherry picked. Its on version 1.1.55-2.
Can you re-test @kbecciv and if the issue does not reoccur can you close this issue and check it off the checklist? 🙂