Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac/Safari - Book Travel - "Learn more" link opens a new window instead of a new tab #8786

Closed
kbecciv opened this issue Apr 26, 2022 · 4 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Apr 26, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre-Condition: Have workspace set up and bank account connected

  1. Access staging.new.expensify.com
  2. Sign into an applause.expensifail,com account
  3. Click on the "Profile" icon and proceed to the user workspace
  4. Click on "Book Travel"
  5. Click on "Learn more"

Expected Result:

The user expects to remain on the same page and a new tab open with the https://community.expensify.com/discussion/7066/introducing-concierge-travel link

Actual Result:

The user is redirected to a completely new window instead of a new tab. This is the only option in all of the workspace settings in which this happens. The user may not notice at first that it is a new window and will then be forced to re access the entire site by changing the URL

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web (Mac/Safari

Version Number: 1.1.57.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5547705_Not_opening_in_new_tab.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 26, 2022

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

@kbecciv is this a regression or did we change the expected behavior?

@kbecciv
Copy link
Author

kbecciv commented Apr 26, 2022

@luacmartins This is from Regression

@luacmartins luacmartins added Improvement Item broken or needs improvement. Reviewing Has a PR in review and removed Improvement Item broken or needs improvement. labels Apr 26, 2022
@melvin-bot melvin-bot bot closed this as completed Apr 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants