Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReportActionsView] Create ReportActionsUtils - move logic out of view layer #8820

Closed
marcaaron opened this issue Apr 28, 2022 · 0 comments
Closed
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@marcaaron
Copy link
Contributor

Problem

ReportActionsView has grown in size and has many responsibilities which can make it hard to reason about. There is logic that does not depend on props or state that can be moved out of the view layer which will help keep things maintainable.

Solution

Move these things into a ReportActionsUtils

This is part of a wider effort to clean up the logic around unread actions and simplify the most critical code in NewDot.

@marcaaron marcaaron added Engineering Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Apr 28, 2022
@marcaaron marcaaron self-assigned this Apr 28, 2022
@melvin-bot melvin-bot bot closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

1 participant