[$500] Unable to cancel or go back when the image is loading - Reported by @adeel0202

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Open any attached image
3. Press the cancel icon or back button to go back when the image is loading

Expected Result:

User should be able to go back even when the image is loading

Actual Result:

User cannot go back when the image is loading

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.57-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

22-04-13-23-03-08.mp4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649873846197949

View all open jobs on GitHub

this job

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joelbettner]

I agree this would be a nice improvement.

[melvin-bot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jboniface]

post here

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @chiragsalian (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jayeshmangwani]

issue is happening in this file
src/components/ImageView/index.native.js

and reason is react-native-image-size package,

App/src/components/ImageView/index.native.js

Line 8 in ec828a2

import ImageSize from 'react-native-image-size';

it is blocking touchable until the getSize function does not resolve values,

App/src/components/ImageView/index.native.js

Line 71 in ec828a2

ImageSize.getSize(this.props.url).then(({width, height}) => {

and solution is that we can use react native core Image.getsize
Image.getSize(this.props.url, (width, height) => {

this package was added in this PR, I am not sure about that this package is mandatory or we can directly use Image.getSize
#6442

[mallenexpensify]

Looks like @phuongpt submitted a new PR 15 hours ago #9621

[chiragsalian]

Yup, just reviewed and merged it 🙂

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[laurenreidexpensify]

Bumping back to weekly as the external labee confused melv

[laurenreidexpensify]

Merged and on staging, should hit prod this week

[mananjadhav]

This is in production but its title wasn't updated.

[phuongpt]

@mallenexpensify seems this task is already done, could you please verify this job on Upwork, thanks.

[mananjadhav]

@mallenexpensify seems this task is already done, could you please verify this job on Upwork, thanks.

@laurenreidexpensify Quick bump. The regression period is complete. PR was deployed 8 days back. For some reason title wasn't updated.

[laurenreidexpensify]

@mananjadhav @phuongpt so sorry here. For context Matt was unexpectedly offline and the messages in Upwork were going to him, not me. I was out for a few days so only saw this now.

@phuongpt has been paid, and @mananjadhav as soon as you accept job in Upwork will issue to you.

Again sorry folks, when teh automation failed this got lost!

[adeel0202]

@laurenreidexpensify, I'm also expecting the reporting bonus.

[mananjadhav]

No worries @laurenreidexpensify. Thanks for helping out here. I've accepted

[adeel0202]

While you're at it, @laurenreidexpensify please check the comment on this issue too. I have been expecting reporting bonus for that issue as well but haven't got any response for many weeks 😄

[laurenreidexpensify]

oh gosh we've lost the plot on this one 😹 on it @adeel0202 - offer sent, thanks for your patience and sorry for all the chaos here!!

[adeel0202]

No worries 😂 accepted the offer for this one.

[phuongpt]

Thank you @laurenreidexpensify!

[laurenreidexpensify]

Okay everyone is paid :) We done :) Thanks folks